cellular-infrastructure
/
osmo-ggsn
mirror of https://gerrit.osmocom.org/osmo-ggsn
9
0
Fork 0
Code Issues Releases Wiki Activity

cosmetic: gtp: Drop commented out code calling pdp_freepdp() 

That code was commented out in 0b076a331e
(year 2003), and indeed it makes no sense to call those in current pdp
lifecycle (they are expected to be freed by the application).

Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37
This commit is contained in:
Pau Espin 2019-08-29 13:48:40 +02:00
parent b4c98e7397
commit 494d873fe3
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
gtp/gtp.c
View File

@ -1752,8 +1752,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Invalid message format\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1764,8 +1762,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing mandatory information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1792,8 +1788,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
}
@ -1805,8 +1799,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1818,8 +1810,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1830,8 +1820,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
}
@ -1844,8 +1832,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1856,8 +1842,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
}
@ -1869,8 +1853,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
}
if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,
@ -1881,8 +1863,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1894,8 +1874,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1907,8 +1885,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
@ -1922,8 +1898,6 @@ int gtp_create_pdp_conf(struct gsn_t *gsn, int version,
"Missing conditional information field\n");
if (gsn->cb_conf)
gsn->cb_conf(type, EOF, pdp, cbp);
/* if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);
pdp_freepdp(pdp); */
return EOF;
}
}