Commit Graph

6135 Commits

Author SHA1 Message Date
Pau Espin 266b61abc6 tests: Fix selection of python version
According to documentation (and personal experience), AM_PATH_PYTHON
selects the highest version of python, no matter if major version is
different, which means if both python2 and 3 are available, 3 will be
chosen an PYTHON will point to "/.../python" which is python3. Apparently,
the macro cannot be easily used to pick highest python2 version.

As {vty,ctrl}_test_runner.py require python2 and are incompatible with
python3, let's instead rely on the system having a "python2" binary
available, which is the case in most distros.

Change-Id: If8e57924ed2c8da7ab7692f58a4bb5c5a970484f
2017-11-28 20:08:19 +01:00
Pau Espin 871f3d7a8c Replace '.' in counter names with ':'
'.' is an illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.

Change-Id: Ie7734cc42151581897d220b445984448ceb57aed
2017-11-28 19:40:37 +01:00
Neels Hofmeyr 8c879b0b35 use default point-code as listed on Point_Codes wiki page
see https://osmocom.org/projects/cellular-infrastructure/wiki/Point_Codes

Change-Id: Ie11f1dfcdd5889d44fefe6cc10472ef1a794cc64
2017-11-24 04:33:08 +01:00
Harald Welte 7547a3fb16 Replace '.' in counter names with ':'
'.' is an illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.

Change-Id: Iec382ec4ee54beb2937431f5a9d8d1171224eebb
2017-11-21 08:51:47 +01:00
Neels Hofmeyr 4984c497fd add --enable-sanitize config option
Change-Id: I3be01e0682b479a71c545f718b68c441a1011b0f
2017-11-18 10:16:52 +00:00
Alexander Couzens 5c4646461f debian: remove doublicated project name in example files
For example:
/usr/share/doc/osmo-sgsn/examples/osmo-sgsn/osmo-sgsn.cfg -> /usr/share/doc/osmo-sgsn/examples/osmo-sgsn.cfg

Change-Id: I77f9665e78e3e55910efb30cb50cefdb138e19f7
2017-11-15 23:32:02 +01:00
Alexander Couzens 2184b24e28 tests/ctrl_test_runner.py: remove BSC/NAT TestRunner
SGSN was splitted out of OpenBSC.

Change-Id: Ie4e44e49e5c904929869b47fc4d608aab1aab75e
2017-11-15 22:03:15 +01:00
Alexander Couzens 4ebb548a96 .gitignore: remove unneeded ignores of bsc/msc/nitb files
sgsn was splitted out of the openbsc repository

Change-Id: I66905432c411291630f66579fa4177936c8f2bcf
2017-11-15 22:02:20 +01:00
Neels Hofmeyr 4a65685e5c vty: skip installing cmds now always installed by default
vty_install_default() and install_default() will soon be deprecated.

Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: Iee1b582a62921cb3205de01ff87d94881e8d411b
2017-11-01 00:52:12 +01:00
Neels Hofmeyr 77806e7aee change default config filename to osmo-sgsn.cfg, not osmo_sgsn.cfg
All other Osmocom programs I know of have a default config file using a dash.
Comply.

Be backwards compatible: when a legacy osmo_sgsn.cfg exists but no
osmo-sgsn.cfg, use the old config file instead. (Verified to work by manual
tests.)

Change-Id: If804da17a7481e79e000fe40ae0d9c4be9722e61
2017-11-01 00:11:30 +01:00
Neels Hofmeyr 000cfe5a19 drop osmo_sgsn.cfg from src/gprs dir
There is a semantically identical config in doc/examples/osmo-sgsn.

Change-Id: I9b9c502afbddcfc02ea70aa8317e0d2f37276c38
2017-10-31 01:58:59 +01:00
Harald Welte 5641e9d41f Tag/Release Version 1.2.0
Change-Id: I44bee346fd698bd51ef305813084afdce0099907
2017-10-28 19:08:27 +02:00
Harald Welte c91e56b8c7 Debian: fix dh_strip rules for creating one -dbg per program
Before this patch, all debug symbols end up in osmo-sgsn-dbg,
with osmo-{gbproxy,gtphub}-dbg being empty.

Change-Id: Ib2ceecb3527855350b69d7413efe42274dc6febd
2017-10-28 19:06:40 +02:00
Harald Welte 78c826bedd Debian: Add systemd service files for osmo-sgsn and osmo-gbproxy
Change-Id: I5a5a80bb19c521e8f20241ed8c02d65b4c937f23
2017-10-28 19:05:45 +02:00
Neels Hofmeyr 4cd0b59cbc jenkins: use osmo-clean-workspace.sh before and after build
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.

Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: I7c3ecd83899f873bdc771ff7445740fea15900ef
2017-10-28 15:08:01 +00:00
Max 16cdb6913a Log address on GTP creation
Change-Id: Ic54a2ff835c9a0ceccf2f718f56371a881dd25b7
2017-10-27 19:00:12 +02:00
Max 6598ad65de Log GTP-U endpoints update
* make gtp_ntoa() public after renaming it to sgsn_gtp_ntoa() to avoid
  confusion with libgtp functions
* use it to log GTP-U endpoints address updates

Change-Id: I96d0f3a63cce338471cc39cc33fd44c39cd2aa73
Related: SYS#3610
2017-10-27 18:49:52 +02:00
Max b9b624011d jenkins: check for IU properly
The bug fixed by Idb034bf2ae749204836ab7e02018d769bb242a9f was not
detected by jenkins because it installs libosmo-sccp unconditionally.

Let's be more strict and install it only when necessary for IU builds to
make sure we can catch such bugs in future.

Change-Id: I573c7fec687edb71d79815b38a3bcf96273c03b3
2017-10-26 15:57:55 +02:00
Max fa46340c64 Fix libosmo-sigtran dependency
That's follow-up fix for I72819462db0b4656fabaa80731342d06ae91fcdf to
make sure IU builds are properly conditioned.

Change-Id: Idb034bf2ae749204836ab7e02018d769bb242a9f
2017-10-26 15:57:55 +02:00
Max da61025790 gbproxy: don't link unnecessary
* remove sigtran include from common_vty.c because nothing uses it
* remove LIBOSMOSIGTRAN_LIBS from generic OSMO_LIBS
* remove LIBOSMOABIS_LIBS from generic OSMO_LIBS

Both LIBOSMOSIGTRAN and LIBOSMOABIS are linked explicitly when necessary
already anyway.

Change-Id: I015a9d858bc2a95f8c9a4aedd3e0a84eadcf84e1
2017-10-26 15:57:55 +02:00
Philipp Maier d394c6c8de configure: fix libosmo-sigtran dependency
the configure script requires libosmo-sigtran even when IU is not
enabled.

move the line that checks for libosmo-sigtran into the conditional
branch for IU

Change-Id: I72819462db0b4656fabaa80731342d06ae91fcdf
2017-10-25 13:12:38 +00:00
Philipp Maier 8a20e7b3fa non-iu-build: guard vty libosmo-sigtran function calls.
The function calls osmo_ss7_vty_go_parent() and gtphub_vty_is_config_node()
are not guarded by an ifdef. The functions are only needed for IU
support where libosmo-sigtran is used.

Guard the function calls with a BUILD_IU

Change-Id: I1c609ef0c344ce825c313335c7e084bf97159262
2017-10-25 13:05:21 +00:00
Philipp Maier b1725a9ae7 log: fix default loglevels
for some log categories the default loglevel is far to verbose.

downgrade all loglevels to LOGL_NOTICE

Change-Id: I3a427ce201c96338a00a84d737d090ac1a77a29f
2017-10-25 13:04:58 +00:00
Max eb6a8f00f1 Fix build after recent rate_ctr patches
It seems like recent changes expanded output of
dump_rate_ctr_group(). Adjust output accordingly to fix the build.

Change-Id: Icc9a53d35be2b0793d7ed25e6fec5bf6c8f84d92
2017-10-25 10:36:43 +02:00
Max b7bd18d037 Fix APN printing
Previously first character of APN was omitted. Fix this by getting rid
of errorneous wrapper function and using osmo_apn_to_str() directly.

The breaking change was introduced in
I7315ffcbed8a54cca2056f313bb7783ad82d0ee9.

Change-Id: Ie13b6cd0066e0370e2adf48d12a363c2e405eaf2
Related: SYS#3610
2017-10-20 18:19:24 +00:00
Max d6984faffc SGSN: check that GSN is created in proper mode
Change-Id: Ie15364fb3c099806ce8a456ef452200305c836f6
2017-10-20 14:28:04 +02:00
Max 322e668fd4 SGSN: print additional GTP-related info
* print libgtp version on startup
* print GSN addresses in 'sh sgsn'

Change-Id: I699a9eb56c4b362984ea8292a3d2b22b71f53c15
Related: SYS#3610
2017-10-20 13:39:57 +02:00
Max bcb19d4f25 SGSN: uncomment BSSGP vty tests
Change-Id: I9181fc0ecd91e96bf6532aa89b811552009a1b7d
2017-10-20 13:38:45 +02:00
Max 72cf554200 Use new FSF address in license header
The issue was uncovered by lintian while checking .deb packaging.

Change-Id: Idfe0e3d61f2604521647e9ef5ffb984db96aabbe
2017-10-17 17:49:59 +02:00
Alexander Couzens 8456fe1b16 debian/rules: show testsuite.log when tests are failing
Change-Id: I4cc6589d4ce95538baf3f30079a3af53cc218268
2017-10-11 08:13:35 +00:00
Max e6fdafb8ae Check for correct P-TMSI allocation
Do not assign new P-TMSI if allocation failed.

Change-Id: Ifa71bbc8df726c74aceaf9ae3eb49e124a53910a
2017-10-09 16:26:43 +02:00
Max 1e6e329817 Move P-TMSI alloc/update into separate function
Remove code duplication by allocating and assigning P-TMSI in a static
function.

Change-Id: Ie5466326a851867d55da389bf18b240acd3f0fc5
2017-10-09 16:21:31 +02:00
Max 3ad0b35fd7 deb: fix copyright file issues
* remove non-existent files
* fix ax_check_compile_flag.m4 license to match autoconf-archive
* fix various .py license to match OpenBSC description

Change-Id: I6881c0a16017d80d142a6cfa756a9c153bee94d3
Related: OS#2527
2017-10-04 12:04:47 +02:00
Max ab65401d37 Use extended logging for PDP contexts
Log additional details (IMSI, NSAPI etc) on PDP context
creation/deletion by using appropriate LOGP() wrappers.

Change-Id: I91a126952ae75ae9ba1f42aac4d26413384bba5d
Related: SYS#3610
2017-10-02 08:38:12 +00:00
Max a8aa4923e7 Cleanup configure checks
* remove unused sqlite3 check
* remove unused NAT/SMPP/BSC/MGCP test checks

Change-Id: I83ae896f57cfb4cb139a42fbf3d77d4b11313f65
2017-10-02 08:37:57 +00:00
Neels Hofmeyr 91d2c59520 jenkins.sh: fix echo string to say osmo-sgsn, not msc
Change-Id: I3e9a1503de55e939179c032c17df53d27bdddd51
2017-09-28 19:07:28 +00:00
Max b83d125b9d jenkins: use osmo-ggsn for tests
Change-Id: I62b29b5531bfb9895318254c41a4e24ba1078fbf
2017-09-28 16:38:11 +02:00
Pau Espin 5878db0e5e Remove unneeded dep libdbi
This dependency is not needed and it's most probably a left over from
openbsc git repository split.

Change-Id: I84b0e2851dc89dca39e87215c71e93457acb884f
2017-09-25 18:46:28 +02:00
Max 8b14382fe7 gbproxy: ensure peer allocation result
gbproxy_peer_alloc() could return NULL which wasn't checked and used
right away. Fix it by making this assumption explicit with
OSMO_ASSERT(); While at it, also format log messages consistently.

Change-Id: Ib10c954e17a479baef31ded54370b35938e00018
2017-09-23 13:57:42 +02:00
Max aea583b379 Remove rest_octets.h
This header is unused anyway.

Change-Id: Ic34f7d3e8f813e020d43be312df940c933bc52b7
2017-09-15 12:01:02 +02:00
Alexander Couzens bdc9bf0c59 debian: fix paths of examples
Change-Id: I054e500be9527b1dd0fc0c21cde2b7b2d2fdfbff
2017-09-14 05:29:17 +02:00
Neels Hofmeyr 4b4c586f03 move include/openbsc to include/osmocom/sgsn
Change-Id: I281ef585fffc2644682c8282224fb1c2da5ca795
2017-09-06 16:47:47 +02:00
Neels Hofmeyr a759e3a07a move openbsc.pc to osmo-sgsn.pc
Change-Id: Iad28d85b2a6d175cbe5d506aa82e7e4d94111eff
2017-09-06 16:47:47 +02:00
Neels Hofmeyr a2ea72915c configure.ac: set name to osmo-sgsn, fix ML addr
Change-Id: I47e9f2307b42d171f2ceeda1e129e2311f611883
2017-09-06 16:47:47 +02:00
Neels Hofmeyr 6fddc86058 rewrite README
Change-Id: If78b74494a00ad230aec94e03b2fe4e905473897
2017-09-06 16:47:47 +02:00
Neels Hofmeyr 0c55de18a0 drop files unrelated to osmo-sgsn
These either remain from openbsc.git or slipped in while applying recent
patches from openbsc.git and do not belong in osmo-sgsn.

Change-Id: Ie9dc7514c3850010d0e9b3ab716b4f4e8d83594f
2017-09-06 16:47:47 +02:00
Neels Hofmeyr f9ced184f5 debian: fix osmo-sgsn.install, tweak VCS link and descriptions
Change-Id: I6493a7ca7d996fab00d99652a74a709c860a3de7
2017-09-06 16:47:47 +02:00
Neels Hofmeyr b95d52e11b jenkins: fix build: remove unused dependencies
Change-Id: Ice81f8541eda2cd5beeacbfd481f3e4283211331
2017-09-03 22:51:13 +02:00
Alexander Couzens d040babfaf rework /debian support to match new osmo-sgsn
Remove old leftover from split of osmo-sgsn out of openbsc.

Change-Id: Ic0135a1118a115e8f053154e280f60674390f43a
2017-08-30 14:18:04 +02:00
Neels Hofmeyr 04b2800fad sccp init: pass no local m3ua addr to use defaults
Remove the FIXMEs because these addresses are configurable via the cs7 /
{as,asp} vty commands.

Change-Id: Ibafda0a9097183c26b21f3380d24dbe293e132e2
2017-08-30 14:16:56 +02:00