cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

gb_proxy: More precise + readable log messages 

* use string representations instead of magic numbers whenever possible
* make text actually describe the specific case, rather than copy+paste
* proper order (foobar indication) not (indication ..... foobar)

Change-Id: I232038da26a9963763c5fc9051b87c9182b27d94
This commit is contained in:
Harald Welte 2020-11-30 10:55:22 +01:00 committed by laforge
parent 7345af835d
commit 95cf9fbfa4
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/gb_proxy.c
View File

@ -1545,10 +1545,8 @@ void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct osmo_gprs_ns2_pri
LOGP(DPCU, LOGL_NOTICE, "NS-NSE %d became unavailable\n", nsp->nsei);
break;
default:
LOGP(DPCU, LOGL_NOTICE,
"NS: %s Unknown prim %d from NS\n",
get_value_string(osmo_prim_op_names, nsp->oph.operation),
nsp->oph.primitive);
LOGP(DPCU, LOGL_NOTICE, "NS: Unknown NS-STATUS.ind cause=%s from NS\n",
gprs_ns2_aff_cause_prim_str(nsp->u.status.cause));
break;
}
}
@ -1567,9 +1565,8 @@ int gprs_ns2_prim_cb(struct osmo_prim_hdr *oph, void *ctx)
nsp = container_of(oph, struct osmo_gprs_ns2_prim, oph);
if (oph->operation != PRIM_OP_INDICATION) {
LOGP(DPCU, LOGL_NOTICE, "NS: %s Unknown prim %d from NS\n",
get_value_string(osmo_prim_op_names, oph->operation),
oph->operation);
LOGP(DPCU, LOGL_NOTICE, "NS: Unexpected primitive operation %s from NS\n",
get_value_string(osmo_prim_op_names, oph->operation));
return 0;
}
@ -1587,10 +1584,9 @@ int gprs_ns2_prim_cb(struct osmo_prim_hdr *oph, void *ctx)
gprs_ns_prim_status_cb(cfg, nsp);
break;
default:
LOGP(DPCU, LOGL_NOTICE,
"NS: %s Unknown prim %d from NS\n",
get_value_string(osmo_prim_op_names, oph->operation),
oph->primitive);
LOGP(DPCU, LOGL_NOTICE, "NS: Unknown prim %s %s from NS\n",
gprs_ns2_prim_str(oph->primitive),
get_value_string(osmo_prim_op_names, oph->operation));
break;
}