From 7d552fc8dafdb619d1e5b0f9bee19e25c81dc8c8 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Thu, 12 Dec 2013 15:45:41 +0100 Subject: [PATCH] vty: Address coverity issue with subscr->name never being NULL Coverity points out that subscr->name is an array and never NULL. Use strlen instead in this check. Fixes: Coverity CID 1040717 --- openbsc/src/libbsc/bsc_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c index b0349816..e0ccfafb 100644 --- a/openbsc/src/libbsc/bsc_vty.c +++ b/openbsc/src/libbsc/bsc_vty.c @@ -873,7 +873,7 @@ static void subscr_dump_vty(struct vty *vty, struct gsm_subscriber *subscr) { vty_out(vty, " ID: %llu, Authorized: %d%s", subscr->id, subscr->authorized, VTY_NEWLINE); - if (subscr->name) + if (strlen(subscr->name)) vty_out(vty, " Name: '%s'%s", subscr->name, VTY_NEWLINE); if (subscr->extension) vty_out(vty, " Extension: %s%s", subscr->extension,