cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

gbproxy_ctrl: Ignore SIG-BVCI in ctrl commands 

Both ctrl commands gbproxy-state and number-of-peers should only
operate on PtP-BVCs. This patch avoids a crash in gbproxy-state and
fixes the count of number-of-peers to only include PtP-BVCs.

Related: SYS#5542, OS#5200
Change-Id: Ida5f9ad0a16b991e77eec0e3cdb779dcfa472fab
This commit is contained in:
Daniel Willmann 2021-07-19 16:08:20 +02:00
parent 5e8c0e813c
commit 5f762597e5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gb_proxy_ctrl.c
View File

@ -103,6 +103,9 @@ static int get_gbproxy_state(struct ctrl_cmd *cmd, void *data)
hash_for_each(cfg->bss_nses, i, nse_peer, list) {
struct gbproxy_bvc *bvc;
hash_for_each(nse_peer->bvcs, j, bvc, list) {
if (bvc->bvci == 0)
continue;
struct gprs_ra_id *raid = &bvc->cell->id.raid;
cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u-%u-%u-%u,%s\n",
@ -127,8 +130,11 @@ static int get_num_peers(struct ctrl_cmd *cmd, void *data)
int i, j;
hash_for_each(cfg->bss_nses, i, nse_peer, list) {
hash_for_each(nse_peer->bvcs, j, bvc, list)
hash_for_each(nse_peer->bvcs, j, bvc, list) {
if (bvc->bvci == 0)
continue;
count++;
}
}
cmd->reply = talloc_strdup(cmd, "");