From 3ea379395f630e37a3b2c63cf158fc312c177eb9 Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Wed, 10 Feb 2021 13:41:14 +0100 Subject: [PATCH] Various comment/whitespace changes Change-Id: I0eeef3ec16c249d65e9358889d21cc4984b7b51f --- src/gb_proxy.c | 3 +-- src/gb_proxy_peer.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gb_proxy.c b/src/gb_proxy.c index f773584f..2d8b5e46 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -461,7 +461,6 @@ static int gbprox_rx_ptp_from_bss(struct gbproxy_nse *nse, struct msgb *msg, uin } else if (TLVP_PRESENT(&tp, BSSGP_IE_IMSI)) { /* FIXME: Use the IMSI as selector? */ rc = gbprox_bss2sgsn_tlli(bss_bvc->cell, msg, NULL, false); - /* rc = gbprox_bss2sgsn_hashed(bss_bvc->cell, msg, NULL); */ } else LOGPBVC(bss_bvc, LOGL_ERROR, "Rx RADIO-STATUS without any of the conditional IEs\n"); break; @@ -1392,7 +1391,7 @@ void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct osmo_gprs_ns2_pri uint8_t cause = BSSGP_CAUSE_OML_INTERV; bvc = gbproxy_bvc_by_bvci(sgsn_nse, 0); if (bvc) - osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause); + osmo_fsm_inst_dispatch(bvc->fi, BSSGP_BVCFSM_E_REQ_RESET, &cause); } break; case GPRS_NS2_AFF_CAUSE_FAILURE: diff --git a/src/gb_proxy_peer.c b/src/gb_proxy_peer.c index 9ea00a98..27d73b8e 100644 --- a/src/gb_proxy_peer.c +++ b/src/gb_proxy_peer.c @@ -93,8 +93,7 @@ struct gbproxy_bvc *gbproxy_bvc_alloc(struct gbproxy_nse *nse, uint16_t bvci) /* We leave allocating the bvc->fi to the caller, as the FSM details depend * on the type of BVC (SIG/PTP) and role (SGSN/BSS) */ - - return bvc; + return bvc; } void gbproxy_bvc_free(struct gbproxy_bvc *bvc) @@ -711,7 +710,7 @@ struct gbproxy_sgsn *gbproxy_sgsn_by_nri(struct gbproxy_config *cfg, uint16_t nr return NULL; } -/*! Seleect a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections +/*! Select a pseudo-random SGSN for a given TLLI, ignoring any SGSN that is not accepting connections * \param[in] cfg The gbproxy configuration * \param[in] sgsn_avoid If not NULL then avoid this SGSN when selecting a new one. Use for load redistribution * \param[in] tlli The tlli to choose an SGSN for. The same tlli will map to the same SGSN as long as no SGSN is