cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

sgsn_test: guard against struct gprs_ra_id changing 

sgsn_test initializes various struct gprs_ra_id without naming the actual
members, which is vulnerable to struct member re-ordering. Name the members
explicitly.

An upcoming ABI change in libosmocore would cause test failures here without
this patch.

Change-Id: I517ed9edf77fac37d9de7a39df24c419a8a65d96
This commit is contained in:
Neels Hofmeyr 2018-02-21 18:30:19 +01:00
parent f8f65b1819
commit 3ab28a2f05
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/sgsn/sgsn_test.c
View File

@ -1644,7 +1644,7 @@ static void test_gmm_cancel(void)
*/
static void test_gmm_ptmsi_allocation(void)
{
struct gprs_ra_id raid = {332, 112, 16464, 96};
struct gprs_ra_id raid = { .mnc=332, .mcc=112, .lac=16464, .rac=96};
struct sgsn_mm_ctx *ctx = NULL;
struct sgsn_mm_ctx *ictx;
uint32_t foreign_tlli;
@ -1847,8 +1847,8 @@ static void test_gmm_ptmsi_allocation(void)
*/
static void test_gmm_routing_areas(void)
{
struct gprs_ra_id raid1 = {332, 112, 16464, 96};
struct gprs_ra_id raid2 = {332, 112, 16464, 97};
struct gprs_ra_id raid1 = { .mnc=332, .mcc=112, .lac=16464, .rac=96};
struct gprs_ra_id raid2 = { .mnc=332, .mcc=112, .lac=16464, .rac=97};
struct sgsn_mm_ctx *ctx = NULL;
struct sgsn_mm_ctx *ictx;
uint32_t ptmsi1;