cellular-infrastructure
/
osmo-gbproxy
mirror of https://gerrit.osmocom.org/osmo-gbproxy
9
0
Fork 0
Code Issues Releases Wiki Activity

gb_proxy_peer: Add some FIXMEs regarding invalid assumptions 

Change-Id: Ibf3d4a3bd58e706dfa44e8cc9ff4823a7759dea5
This commit is contained in:
Harald Welte 2020-11-24 09:27:38 +01:00
parent fe05958610
commit 09ea490a79
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/gb_proxy_peer.c
View File

@ -105,6 +105,7 @@ struct gbproxy_peer *gbproxy_peer_by_nsei(struct gbproxy_config *cfg,
}
/* look-up a peer by its Routeing Area Identification (RAI) */
/* FIXME: this doesn't make sense, as RA can span multiple peers! */
struct gbproxy_peer *gbproxy_peer_by_rai(struct gbproxy_config *cfg,
const uint8_t *ra)
{
@ -117,6 +118,7 @@ struct gbproxy_peer *gbproxy_peer_by_rai(struct gbproxy_config *cfg,
}
/* look-up a peer by its Location Area Identification (LAI) */
/* FIXME: this doesn't make sense, as LA can span multiple peers! */
struct gbproxy_peer *gbproxy_peer_by_lai(struct gbproxy_config *cfg,
const uint8_t *la)
{
@ -129,6 +131,7 @@ struct gbproxy_peer *gbproxy_peer_by_lai(struct gbproxy_config *cfg,
}
/* look-up a peer by its Location Area Code (LAC) */
/* FIXME: this doesn't make sense, as LAC can span multiple peers! */
struct gbproxy_peer *gbproxy_peer_by_lac(struct gbproxy_config *cfg,
const uint8_t *la)
{
@ -151,6 +154,7 @@ struct gbproxy_peer *gbproxy_peer_by_bssgp_tlv(struct gbproxy_config *cfg,
return gbproxy_peer_by_bvci(cfg, bvci);
}
/* FIXME: this doesn't make sense, as RA can span multiple peers! */
if (TLVP_PRESENT(tp, BSSGP_IE_ROUTEING_AREA)) {
uint8_t *rai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA);
/* Only compare LAC part, since MCC/MNC are possibly patched.
@ -159,6 +163,7 @@ struct gbproxy_peer *gbproxy_peer_by_bssgp_tlv(struct gbproxy_config *cfg,
return gbproxy_peer_by_lac(cfg, rai);
}
/* FIXME: this doesn't make sense, as LA can span multiple peers! */
if (TLVP_PRESENT(tp, BSSGP_IE_LOCATION_AREA)) {
uint8_t *lai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA);
return gbproxy_peer_by_lac(cfg, lai);