Commit Graph

22 Commits

Author SHA1 Message Date
Pau Espin d3be026b93 Rename CBSP,SABP,SBcAP structs and APIs
Rename osmo_*_cbc -> cbc_*_mgr:
Now they only hold TCP/SCTP server related conns, but will also hold
TCP/SCTP client conns in the near future.

Rename osmo_cbc_*_client -> cbc_*_link:
The term "client" is confusing, since it doesn't exist in CBSP/SBcAP,
and will later support connecting to server at TCP/SCTP level.
Let's use "link" instead, similar to what's used in osmo-bsc which
already supports both TCP client and server modes.

Change-Id: Ia9d26dc1593c8ee08dce348fe9f5f4c9398ea2a5
2022-07-20 20:10:13 +02:00
Pau Espin 0f17a212d1 cbsp_server.c: Drop unused code
This will be properly implemented soon.

Change-Id: I5165e3c64d2c933027019264f68f94fb0c18e0e9
2022-07-20 19:48:02 +02:00
Pau Espin 881d5bab4b Get rid of internal.h
Let's create missing header files and move stuff around to have a clear
view of who implements what.

Change-Id: Ib32091d716b33bca58e2d3acf8840b52824c0bd3
2022-07-20 19:23:36 +02:00
Pau Espin 1486ac0191 Split cbc_peer to its own .c and .h files
Change-Id: I41c890d81e76ac1a1c89d42af70a1f0631e9724e
2022-07-20 17:58:45 +02:00
Pau Espin a12affbc0f cbsp: Clean up conn closed paths
Change-Id: I08d1da97f0a2d83f7f48c59bc4dbd669f4f814b3
2022-07-07 16:22:36 +02:00
Pau Espin 8dc5648176 Move header files to include/osmocom/cbc/ dir
Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3
2022-07-04 13:35:47 +02:00
Pau Espin 18f144662e cbsp_server: Exit process gracefully if binding socket fails
Change-Id: I6fac793aa6975cacfeffc3389167bd00864a8a08
2022-07-01 17:24:28 +02:00
Pau Espin 5b25874c2b cbsp_server: Reorder logged message
log macro needs to be changed since it uses cbsp_cbc_client_name() which
accesses client->conn which is NULL in there.

Change-Id: Ic444c749476bb1626df5494c00021c5e1a9f24b9
2022-06-21 12:11:49 +02:00
Pau Espin b3ee9ca764 Rework cbsp_cbc_create() params
There's no need to pass the specific params. Let's simply get whatever
need from the global config in the function.
This makes it easier to extend it to more params if needed.
Also, when we add SBc-AP support, the params that have to be passed to
the counter part function are different, so let's simplify param
passing here.

While at it, rename also the callback function to contain "cbsp" on it,
since it is cbsp specific.

Change-Id: Ia2362757275e7cbce82b64c7c2a0798276d964c3
2022-06-21 12:11:49 +02:00
Harald Welte e74594b247 VTY: don't save dynamically-allocated "unknown" peers
The VTY code should write/save only those peers that were configured
using the VTY.

Closes: OS#4929
Change-Id: If02694be4e4cb9cb27e7d9d07e533bfed4a999a9
2021-01-24 23:29:03 +01:00
Harald Welte 76101c4a86 More massive CBC WIP
Using this state we can actually successfully add mesasges via
the REST interface and see them being sent via CBSP to the BSCs,
who then transmit to BTSs who send it to MSs and the MSs show them...

Change-Id: If29bd4bbbf88a0ca58de9ff29ad524b0a7262a8e
2021-01-03 13:14:46 +01:00
Harald Welte 2849727777 cbsp_server: improve log levels
Change-Id: Id5408d8be4cdd8bed1c21008efe1f291d94b00ed
2021-01-02 12:11:46 +01:00
Harald Welte af60bc000c cbsp_server: Use peer name in logs instead of osmo_sock_get_name2()
If we know the peer of a client, and that peer has a name, log lines
shall use that name as context, rather than the somewhat difficult
to read osmo_sock_get_name2() result.

Change-Id: I183cbfa4b541fa4e2b96a00635cb17d91a34ae83
2021-01-02 11:40:28 +01:00
Harald Welte 7313772cdb WIP
Change-Id: I240b4be2fbb316e423d1bf366061b08912814011
2020-12-31 19:07:41 +01:00
Harald Welte 3bffde541e fix use-after-free in cbsp disconnect
Change-Id: I7d15606a83f13599300553b5d7b6532b2e5d90fe
2020-12-31 14:25:24 +01:00
Harald Welte 0b9fd3945a cbsp_server: move llist_add() up a bit to ensure llist_del() works in error paths
Change-Id: I39b977cbc3a3cbc81b0fb322158d9e81baf9a8dc
2019-08-05 22:09:34 +02:00
Harald Welte bdf74e9a89 CBSP Server improvements
Change-Id: Id4e661ab9281c394eaa82430d49f7e3dfeab3f57
2019-08-05 22:08:53 +02:00
Harald Welte b8f7c3bd5e cbsp_server: Allow for bind to non-standard port + bind to IP
Change-Id: I7bf0002b514318ca8014bf92a7ce9a15ee4227c5
2019-07-20 15:32:58 +02:00
Harald Welte 5a17cf671b osmo_cbsp_recv_buffered() is now part of libosmocore
Change-Id: I93995e6c611701ca8688de8904adf8ea57292e69
2019-07-20 14:44:22 +02:00
Harald Welte 0560768ad2 update CBSP API to current libosmocore
Change-Id: I719b04e10cc2d6e33ac9655bc1166a70bdc7e95b
2019-07-20 14:44:18 +02:00
Harald Welte 63b7905fa3 Initial (building) start of OsmoCBC (Cell Broadcast Centre)
this is far from doing anything useful yet. Stay tuned.

Change-Id: I64a6833ce068db60d713d0fa318a1d8093e37be9
2019-05-06 23:15:23 +02:00
Harald Welte 6c8bf25d11 initial checkin of cbsp_server.c 2019-05-05 14:24:43 +02:00