cellular-infrastructure
/
osmo-cbc
mirror of https://gerrit.osmocom.org/osmo-cbc
9
0
Fork 0
Code Issues Releases Wiki Activity

Rename functions generating CBSP/SBc-AP Write-Replace request 

Previous naming is misleading, as it seems to indicate the function is
used to generate any kind of message, which is wrong.

Change-Id: Ib0228c64bbf104accdbbebb6076004a6a1f44c6f
This commit is contained in:
Pau Espin 2022-07-26 11:08:28 +02:00
parent 7beca6fda0
commit 9ce5d4bad7
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/osmocom/cbc/cbsp_msg.h
View File

@ -2,4 +2,4 @@
#include <osmocom/gsm/cbsp.h>
struct cbc_message;
struct osmo_cbsp_decoded *cbcmsg_to_cbsp(void *ctx, const struct cbc_message *cbcmsg);
struct osmo_cbsp_decoded *cbsp_gen_write_replace_req(void *ctx, const struct cbc_message *cbcmsg);

2
include/osmocom/cbc/sbcap_msg.h
View File

@ -7,5 +7,5 @@
struct cbc_message;
typedef struct SBcAP_SBC_AP_PDU SBcAP_SBC_AP_PDU_t;
SBcAP_SBC_AP_PDU_t *cbcmsg_to_sbcap(void *ctx, const struct cbc_message *cbcmsg);
SBcAP_SBC_AP_PDU_t *sbcap_gen_write_replace_warning_req(void *ctx, const struct cbc_message *cbcmsg);
SBcAP_SBC_AP_PDU_t *sbcap_gen_stop_warning_req(void *ctx, const struct cbc_message *cbcmsg);

4
src/cbc_message.c
View File

@ -65,7 +65,7 @@ int peer_new_cbc_message(struct cbc_peer *peer, struct cbc_message *cbcmsg)
peer->name);
return -ENOTCONN;
}
if (!(cbsp = cbcmsg_to_cbsp(peer, cbcmsg))) {
if (!(cbsp = cbsp_gen_write_replace_req(peer, cbcmsg))) {
LOGP(DCBSP, LOGL_ERROR, "[%s] Tx CBSP: msg gen failed\n",
peer->name);
return -EINVAL;
@ -79,7 +79,7 @@ int peer_new_cbc_message(struct cbc_peer *peer, struct cbc_message *cbcmsg)
peer->name);
return -ENOTCONN;
}
if (!(sbcap = cbcmsg_to_sbcap(peer, cbcmsg))) {
if (!(sbcap = sbcap_gen_write_replace_warning_req(peer, cbcmsg))) {
LOGP(DSBcAP, LOGL_ERROR, "[%s] Tx SBc-AP: msg gen failed\n",
peer->name);
return -EINVAL;

2
src/cbsp_msg.c
View File

@ -50,7 +50,7 @@ static int cbcmsg_to_cbsp_cell_list(const void *ctx, struct osmo_cbsp_cell_list
}
/* generate a CBSP WRITE-REPLACE from our internal representation */
struct osmo_cbsp_decoded *cbcmsg_to_cbsp(void *ctx, const struct cbc_message *cbcmsg)
struct osmo_cbsp_decoded *cbsp_gen_write_replace_req(void *ctx, const struct cbc_message *cbcmsg)
{
struct osmo_cbsp_write_replace *wrepl;
const struct smscb_message *smscb = &cbcmsg->msg;

2
src/sbcap_msg.c
View File

@ -84,7 +84,7 @@ static void msgb_put_sbcap_cell_list(const struct cbc_message *cbcmsg, void *voi
/* generate a SBc-AP WRITE-REPLACE WARNING REQUEST from our internal representation.
* 3GPP TS 36.413 9.1.13.1
*/
SBcAP_SBC_AP_PDU_t *cbcmsg_to_sbcap(void *ctx, const struct cbc_message *cbcmsg)
SBcAP_SBC_AP_PDU_t *sbcap_gen_write_replace_warning_req(void *ctx, const struct cbc_message *cbcmsg)
{
const struct smscb_message *smscb = &cbcmsg->msg;
SBcAP_SBC_AP_PDU_t *pdu;