cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf 

The function pcu_tx_pch_data_cnf() gets a parameter fn (frame number).
This parameter is then used to populate the member fn in
gsm_pcu_if_data_cnf_dt of the PCUIF protocol. However, the PCU only uses
this parameter for logging and nothing else. Hence it it is not needed
and we can remove it.

Related: OS#5927
Depends: osmo-pcu.git I35bc99eaec5d0287ae3916bc668f0babaddfd6ce
Change-Id: Id1c8fa77725129ec2ea7e92e1df493f35a277659
This commit is contained in:
Philipp Maier 2023-08-08 17:01:29 +02:00
parent bbb3a1ed17
commit ff085f63c9
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/osmo-bts/pcu_if.h
View File

@ -23,7 +23,7 @@ int pcu_tx_rach_ind(uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr,
int pcu_tx_time_ind(uint32_t fn);
int pcu_tx_interf_ind(const struct gsm_bts_trx *trx, uint32_t fn);
int pcu_tx_pag_req(const uint8_t *identity_lv, uint8_t chan_needed);
int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t msg_id);
int pcu_tx_pch_data_cnf(uint32_t msg_id);
int pcu_tx_susp_req(struct gsm_lchan *lchan, uint32_t tlli, const uint8_t *ra_id, uint8_t cause);
int pcu_sock_send(struct msgb *msg);

2
src/common/paging.c
View File

@ -734,7 +734,7 @@ int paging_gen_msg(struct paging_state *ps, uint8_t *out_buf, struct gsm_time *g
GSM_MACBLOCK_LEN);
/* send a confirmation back (if required) */
if (pr[num_pr]->u.macblock.confirm)
pcu_tx_pch_data_cnf(gt->fn, pr[num_pr]->u.macblock.msg_id);
pcu_tx_pch_data_cnf(pr[num_pr]->u.macblock.msg_id);
talloc_free(pr[num_pr]);
return GSM_MACBLOCK_LEN;
}

3
src/common/pcu_sock.c
View File

@ -618,7 +618,7 @@ int pcu_tx_pag_req(const uint8_t *identity_lv, uint8_t chan_needed)
return pcu_sock_send(msg);
}
int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t msg_id)
int pcu_tx_pch_data_cnf(uint32_t msg_id)
{
struct gsm_bts *bts;
struct msgb *msg;
@ -636,7 +636,6 @@ int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t msg_id)
pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) {
.sapi = PCU_IF_SAPI_PCH_DT,
.msg_id = msg_id,
.fn = fn,
};
return pcu_sock_send(msg);