From f7c7d2baf6e2b6cd4a295c21040fd4e6c5492bf1 Mon Sep 17 00:00:00 2001
From: Vadim Yanitskiy <vyanitskiy@sysmocom.de>
Date: Thu, 4 Feb 2021 13:40:19 +0100
Subject: [PATCH] pcu_sock: pcu_tx_si_all(): fix returning ununitialized rc

Change-Id: Ic78614bebade701db14439aa64ecf89c7104a639
Fixes: CID#216932
---
 src/common/pcu_sock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index d7092f909..250491f17 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -777,7 +777,7 @@ static int pcu_tx_si_all(struct gsm_bts *bts)
 		if (GSM_BTS_HAS_SI(bts, si_types[i])) {
 			rc = pcu_tx_si(bts, si_types[i], true);
 			if (rc < 0)
-				rc = -EINVAL;
+				return rc;
 		} else {
 			LOGP(DPCU, LOGL_INFO,
 			     "SI%s is not available on PCU connection\n",
@@ -785,7 +785,7 @@ static int pcu_tx_si_all(struct gsm_bts *bts)
 		}
 	}
 
-	return rc;
+	return 0;
 }
 
 static int pcu_rx_txt_ind(struct gsm_bts *bts,