cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

pcu_sock: fix uninitalized returncode value 

In function pcu_tx_si_all(), the variable rc is not initalized. If
pcu_tx_si() fails, then rc is populated with value -EINVAL, but if all
si transmissions succeed, which is the normal case, rc remains
uninitalized.

Change-Id: I571fdb4f175fb259b77f989554f569fc2230dfe6
Related: CID#216932
This commit is contained in:
Philipp Maier 2021-02-04 11:52:37 +01:00 committed by laforge
parent f7c7d2baf6
commit ed7bca6b33
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/pcu_sock.c
View File

@ -771,7 +771,7 @@ static int pcu_tx_si_all(struct gsm_bts *bts)
const enum osmo_sysinfo_type si_types[3] =
{ SYSINFO_TYPE_1, SYSINFO_TYPE_3, SYSINFO_TYPE_13 };
unsigned int i;
int rc;
int rc = 0;
for (i = 0; i < ARRAY_SIZE(si_types); i++) {
if (GSM_BTS_HAS_SI(bts, si_types[i])) {