cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

Make T200 default initialization even more robust 

There's no need to use memcpy(), which adds the risk that the types of
source and destination are not the same (see previous commit). Iterating
over the array and assigning each element is more robust.
This commit is contained in:
Harald Welte 2016-01-17 21:08:20 +01:00
parent 3d431bb4eb
commit e60b9d1de6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/bts.c
View File

@ -76,7 +76,7 @@ int bts_init(struct gsm_bts *bts)
{
struct gsm_bts_role_bts *btsb;
struct gsm_bts_trx *trx;
int rc;
int rc, i;
static int initialized = 0;
void *tall_rtp_ctx;
@ -109,7 +109,8 @@ int bts_init(struct gsm_bts *bts)
btsb->max_ta = 63;
btsb->ny1 = 4;
btsb->t3105_ms = 300;
memcpy(btsb->t200_ms, oml_default_t200_ms, sizeof(btsb->t200_ms));
for (i = 0; i < ARRAY_SIZE(btsb->t200_ms); i++)
btsb->t200_ms[i] = oml_default_t200_ms[i];
/* default RADIO_LINK_TIMEOUT */
btsb->radio_link_timeout = 32;