cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

l1sap: l1sap_chan_act(): remove unused *tp argument 

Change-Id: I2030f05b55fc9370e71ff12b26ffe1142f4acfc8
This commit is contained in:
Vadim Yanitskiy 2022-04-11 06:01:19 +03:00 committed by fixeria
parent 7af62e2d0f
commit bab872cc0d
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/osmo-bts/l1sap.h
View File

@ -96,7 +96,7 @@ void l1sap_rtp_rx_cb(struct osmo_rtp_socket *rs, const uint8_t *rtp_pl,
uint32_t timestamp, bool marker);
/* channel control */
int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr, struct tlv_parsed *tp);
int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr);
int l1sap_chan_rel(struct gsm_bts_trx *trx, uint8_t chan_nr);
int l1sap_chan_deact_sacch(struct gsm_bts_trx *trx, uint8_t chan_nr);
int l1sap_chan_modify(struct gsm_bts_trx *trx, uint8_t chan_nr);

2
src/common/l1sap.c
View File

@ -1927,7 +1927,7 @@ static int l1sap_chan_act_dact_modify(struct gsm_bts_trx *trx, uint8_t chan_nr,
return l1sap_down(trx, &l1sap);
}
int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr, struct tlv_parsed *tp)
int l1sap_chan_act(struct gsm_bts_trx *trx, uint8_t chan_nr)
{
struct gsm_lchan *lchan = get_lchan_by_chan_nr(trx, chan_nr);
int rc;

2
src/common/pcu_sock.c
View File

@ -884,7 +884,7 @@ static int pcu_rx_act_req(struct gsm_bts *bts,
return -EINVAL;
}
if (act_req->activate)
l1sap_chan_act(trx, gsm_lchan2chan_nr(lchan), NULL);
l1sap_chan_act(trx, gsm_lchan2chan_nr(lchan));
else
l1sap_chan_rel(trx, gsm_lchan2chan_nr(lchan));

2
src/common/rsl.c
View File

@ -1988,7 +1988,7 @@ static int rsl_rx_chan_activ(struct msgb *msg)
lchan->top_acch_active = false;
/* actually activate the channel in the BTS */
rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr, &tp);
rc = l1sap_chan_act(lchan->ts->trx, dch->chan_nr);
if (rc < 0)
return rsl_tx_chan_act_acknack(lchan, -rc);

4
tests/handover/handover_test.c
View File

@ -102,12 +102,12 @@ int main(int argc, char **argv)
/* create two lchans for handover */
lchan = &trx->ts[1].lchan[0];
lchan->type = GSM_LCHAN_SDCCH;
l1sap_chan_act(lchan->ts->trx, 0x09, NULL);
l1sap_chan_act(lchan->ts->trx, 0x09);
lchan = &trx->ts[2].lchan[0];
lchan->type = GSM_LCHAN_TCH_F;
lchan->ho.active = HANDOVER_ENABLED;
lchan->ho.ref = 23;
l1sap_chan_act(lchan->ts->trx, 0x0a, NULL);
l1sap_chan_act(lchan->ts->trx, 0x0a);
OSMO_ASSERT(msgb_dequeue(&trx->rsl_link->tx_list));
OSMO_ASSERT(msgb_dequeue(&trx->rsl_link->tx_list));
OSMO_ASSERT(!msgb_dequeue(&trx->rsl_link->tx_list));