cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

osmo-bts-octphy: Remove bogus warning about BS_AG_BLKS_RES 

Contrary to osmo-bts-sysmo, the OCTPHY-2G does not have different L1
SAPI for AGCH and PCH.  It uses cOCTVC1_GSM_SAPI_ENUM_PCH_AGCH for both,
and we convert that to the cbits=0x12 (Downlink CCCH) on the L1SAP.

The code above L1SAP can hence freely decide if it wants to respond with
an AGCH or PCH message, based on its knowledge of BS_AG_BLKS_RES,
without the OCTPHY specific code having to do anything about it.

Hence, there's nothing to do, and the warning can be removed

Change-Id: Ic1038b8dc57bdaf05493cd8479355b960275ea41
Related: OS#1575
This commit is contained in:
Harald Welte 2017-12-03 10:54:02 +01:00
parent 57ce53d8aa
commit a7bfb6c8da
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/osmo-bts-octphy/l1_if.c
View File

@ -516,7 +516,6 @@ static int ph_data_req(struct gsm_bts_trx *trx, struct msgb *msg,
} else if (L1SAP_IS_CHAN_BCCH(chan_nr)) {
sapi = cOCTVC1_GSM_SAPI_ENUM_BCCH;
} else if (L1SAP_IS_CHAN_AGCH_PCH(chan_nr)) {
#warning Set BS_AG_BLKS_RES
sapi = cOCTVC1_GSM_SAPI_ENUM_PCH_AGCH;
} else {
LOGP(DL1C, LOGL_NOTICE, "unknown prim %d op %d "