cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

power_ctrl_params_def_reset(): set .ctrl_interval for both UL/DL 

For the sake of consistency and code readability, initialize the
power loop control interval (P_Con_INTERVAL) for both Uplink and
Downlink directions in the same function.

Change-Id: If7c804e51eb104d9fe73294a3867ab3b551d83c3
This commit is contained in:
Vadim Yanitskiy 2022-04-08 01:32:36 +03:00 committed by fixeria
parent dd7bed3415
commit 94f7b4753a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/common/power_control.c
View File

@ -404,9 +404,6 @@ int lchan_bs_pwr_ctrl(struct gsm_lchan *lchan,
/* Default MS/BS Power Control parameters (see 3GPP TS 45.008, table A.1) */
const struct gsm_power_ctrl_params power_ctrl_params_def = {
.ctrl_interval = 1, /* Trigger loop every second SACCH block. TS 45.008 sec 4.7.1 */
/* Power increasing/reducing step size (optimal defaults) */
.inc_step_size_db = 4, /* quickly increase MS/BS power */
.red_step_size_db = 2, /* slowly decrease MS/BS power */
@ -569,7 +566,10 @@ const struct gsm_power_ctrl_params power_ctrl_params_def = {
void power_ctrl_params_def_reset(struct gsm_power_ctrl_params *params, bool is_bs_pwr)
{
*params = power_ctrl_params_def;
/* Trigger loop every N-th SACCH block. See 3GPP TS 45.008 section 4.7.1. */
if (!is_bs_pwr)
/* Trigger loop every fourth SACCH block (1.92s). TS 45.008 sec 4.7.1: */
params->ctrl_interval = 2;
params->ctrl_interval = 2; /* N=4 (1.92s) */
else
params->ctrl_interval = 1; /* N=2 (0.960) */
}