cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

VTY: fix ambiguity in BTS specific command definitions 

Most of the BTS specific VTY commands restrict BTS number to '<0-0>',
while bts_c0_power_red_cmd has '<0-255>'.  This confuses libosmovty:

  OsmoBTS# bts ?
    <0-0>    BTS number
    <0-255>  BTS Number

  OsmoBTS# bts 0 ?
  % Ambiguous command.

  OsmoBTS# bts 0 c0-power-red 0
  % Ambiguous command.

Let's stick to '<0-0>', we don't support multiple BTS anyway.

Change-Id: I937ac421143678b97627c1bc4fe573831ce097f6
This commit is contained in:
Vadim Yanitskiy 2022-03-07 12:21:20 +03:00 committed by laforge
parent d84567779c
commit 8ec3f28fad
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/vty.c
View File

@ -1329,7 +1329,7 @@ DEFUN_HIDDEN(radio_link_timeout, radio_link_timeout_cmd, "bts <0-0> radio-link-t
DEFUN(bts_c0_power_red,
bts_c0_power_red_cmd,
"bts <0-255> c0-power-red <0-6>",
"bts <0-0> c0-power-red <0-6>",
"BTS Specific Commands\n" BTS_NR_STR
"BCCH carrier power reduction operation\n"
"Power reduction value (in dB, even numbers only)\n")

2
tests/osmo-bts.vty
View File

@ -107,7 +107,7 @@ OsmoBTS# list
show timer [(bts|abis)] [TNNNN]
bts <0-0> trx <0-255> ts <0-7> (lchan|shadow-lchan) <0-7> rtp jitter-buffer <0-10000>
test send-failure-event-report <0-255>
bts <0-255> c0-power-red <0-6>
bts <0-0> c0-power-red <0-6>
show e1_driver
show e1_line [<0-255>] [stats]
show e1_timeslot [<0-255>] [<0-31>]