cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

TRX: Fix, never send confirm for DEACT SACCH request (TS 05.08 4.6) 

Sending it would cause BSC to change to a state, where it does not release
rf channel.
This commit is contained in:
Andreas Eversberg 2013-02-07 16:58:00 +01:00 committed by Harald Welte
parent e0959e7929
commit 7d684d6866
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/osmo-bts-trx/l1_if.c
View File

@ -457,6 +457,7 @@ int bts_model_l1sap_down(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap)
/* activate dedicated channel */
trx_sched_set_lchan(l1h, chan_nr, 0x00, 0, 1);
trx_sched_set_lchan(l1h, chan_nr, 0x00, 1, 1);
/* activate assoicated channel */
trx_sched_set_lchan(l1h, chan_nr, 0x40, 0, 1);
trx_sched_set_lchan(l1h, chan_nr, 0x40, 1, 1);
/* init lapdm */
@ -476,16 +477,17 @@ int bts_model_l1sap_down(struct gsm_bts_trx *trx, struct osmo_phsap_prim *l1sap)
"chan_nr 0x%02x\n", chan_nr);
break;
}
/* deactivate assoicated channel */
trx_sched_set_lchan(l1h, chan_nr, 0x40, 0, 0);
trx_sched_set_lchan(l1h, chan_nr, 0x40, 1, 0);
/* deactivate dedicated channel */
if (!l1sap->u.info.u.act_req.sacch_only) {
trx_sched_set_lchan(l1h, chan_nr, 0x00, 0, 0);
trx_sched_set_lchan(l1h, chan_nr, 0x00, 1, 0);
/* confirm only on dedicated channel */
mph_info_chan_confirm(l1h, chan_nr,
PRIM_INFO_DEACTIVATE, 0);
}
trx_sched_set_lchan(l1h, chan_nr, 0x40, 0, 0);
trx_sched_set_lchan(l1h, chan_nr, 0x40, 1, 0);
/* confirm */
mph_info_chan_confirm(l1h, chan_nr,
PRIM_INFO_DEACTIVATE, 0);
break;
default:
LOGP(DL1C, LOGL_NOTICE, "unknown MPH-INFO.req %d\n",