cellular-infrastructure
/
osmo-bts
mirror of https://gerrit.osmocom.org/osmo-bts
9
0
Fork 0
Code Issues Releases Wiki Activity

bts_model_apply_oml(): Drop unneded code 

Calls to bts_model_apply_oml() are done only for BTS, RCARRIER and
RCHANNEL NM Objects in their respective Rx code paths (and they will
be moved to respective FSMs in follow up patches). This function is
never called with any of the GPRS NM objects.

These NM Objectes have the NM_MT_IPACC_SET_ATTR msg ACKED/NACKED in its
own path:
oml_ipa_set_attr()
	rc = oml_ipa_mo_set_attr()
	return oml_fom_ack_nack(msg, rc);

Change-Id: I1a0d38a122f50ffe749ebc4f1cc11235ca516586
This commit is contained in:
Pau Espin 2023-04-03 18:47:11 +02:00
parent 914e55caf3
commit 7a646f963b
7 changed files with 0 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/osmo-bts-lc15/oml.c
View File

@ -1814,14 +1814,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
struct gsm_bts_trx *trx;
struct lc15l1_hdl *fl1h;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_RADIO_ATTR:
trx = obj;

8
src/osmo-bts-oc2g/oml.c
View File

@ -1824,14 +1824,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
struct oc2gl1_hdl *fl1h;
uint8_t cell_size;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_RADIO_ATTR:
trx = obj;

8
src/osmo-bts-octphy/l1_oml.c
View File

@ -1754,14 +1754,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
int rc;
struct gsm_bts_trx *trx;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_RADIO_ATTR:
trx = obj;

8
src/osmo-bts-omldummy/bts_model.c
View File

@ -104,14 +104,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
};
int rc;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_BTS_ATTR:
ev_data.cause = vbts_set_bts(obj);

8
src/osmo-bts-sysmo/oml.c
View File

@ -1727,14 +1727,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
struct gsm_bts_trx *trx;
struct femtol1_hdl *fl1h;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_RADIO_ATTR:
trx = obj;

8
src/osmo-bts-trx/l1_if.c
View File

@ -559,14 +559,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
};
int rc;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_BTS_ATTR:
ev_data.cause = trx_set_bts(obj);

8
src/osmo-bts-virtual/bts_model.c
View File

@ -139,14 +139,6 @@ int bts_model_apply_oml(struct gsm_bts *bts, struct msgb *msg,
};
int rc;
/* TODO: NM Object without FSM: */
switch (foh->obj_class) {
case NM_OC_GPRS_NSE:
case NM_OC_GPRS_CELL:
case NM_OC_GPRS_NSVC:
return oml_fom_ack_nack(ev_data.msg, ev_data.cause);
}
switch (foh->msg_type) {
case NM_MT_SET_BTS_ATTR:
ev_data.cause = vbts_set_bts(obj);