cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity
osmo-bsc/src/libbsc
History
Harald Welte d6012ffc19 sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6 
Fixes a regression in the code generating SI5* and SI6 on SACCH,
where the L@ pseudo-length is not part of the 'struct' definition
we have in gsm_04_08.h and hence has to be encoded manually into
the first byte of the SI buffer.

We were doing this correctly until April 2017, when the following
patch was merged:

> commit 6f0e50c833
> Author: Max <msuraev@sysmocom.de>
> Date:   Wed Apr 12 15:30:54 2017 +0200
>
>     Prepare for extended SI2quater support

This patch cacidentially overwrote the l2_plen that was just enoded,
as the 'struct' was no longer pointing to 'output' (si_buf+1), but
now directly to the start of the si_buf.

NOTE: The Wireshark RSL dissector (and more recently also LAPDm)
contain a similar bug, so the SACCH will not be decoded correctly
after applying this patch. Nevertheless, it's correct.

Change-Id: Ie8c907b1317566670aeb68f933ceefd552c17565
Closes: #3059
Related: #2963
 		2018-03-12 00:28:58 +01:00
..
Makefile.am Add support for Access Control Class ramping. 2018-02-27 14:29:39 +00:00
a_reset.c a_reset: Add FSM event names 2018-03-01 23:08:15 +00:00
abis_nm.c gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf 2018-03-05 05:35:54 +01:00
abis_nm_ipaccess.c move openbsc/* to repos root 2017-08-27 03:52:43 +02:00
abis_nm_vty.c vty: skip installing cmds now always installed by default 2017-11-01 00:48:52 +01:00
abis_om2000.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
abis_om2000_vty.c compiler warnings: drop some unused variables 2017-11-29 17:37:18 +00:00
abis_rsl.c HO: lchan: store last seen measurement report nr, tweak log 2018-02-19 15:51:18 +00:00
acc_ramp.c Add support for Access Control Class ramping. 2018-02-27 14:29:39 +00:00
arfcn_range_encode.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bsc_api.c compiler warning: chan_compat_with_mode(): clearly handle all enum vals 2018-03-05 00:59:44 +01:00
bsc_ctrl_commands.c implement support for 3-digit MNC with leading zeros 2018-03-07 15:34:48 +00:00
bsc_ctrl_lookup.c Support control connection status query for a particular MSC. 2018-01-09 11:18:10 +00:00
bsc_dyn_ts.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bsc_init.c implement support for 3-digit MNC with leading zeros 2018-03-07 15:34:48 +00:00
bsc_msc.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bsc_rf_ctrl.c Make TRX rf locking more visible 2017-09-08 08:31:02 +00:00
bsc_rll.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bsc_subscriber.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bsc_vty.c implement support for 3-digit MNC with leading zeros 2018-03-07 15:34:48 +00:00
bts_ericsson_rbs2000.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bts_init.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bts_ipaccess_nanobts.c Revert "Generate the S_L_INP_TEI_UP signal earlier." 2018-03-02 14:15:23 +00:00
bts_ipaccess_nanobts_omlattr.c osmo-bts/nanobts: Set RACH_Busy Threshold to -90 dBm 2018-02-27 10:09:43 +01:00
bts_nokia_site.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bts_siemens_bs11.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bts_sysmobts.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
bts_unknown.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
chan_alloc.c Add support for Access Control Class ramping. 2018-02-27 14:29:39 +00:00
e1_config.c Make RSL connection attempts time out. 2018-02-13 18:08:28 +01:00
gsm_04_08_utils.c gsm48_parse_meas_rep(): set num_cell=0 if no neighbor cells are reported 2018-03-08 03:28:54 +01:00
gsm_04_80_utils.c move include/openbsc to include/osmocom/bsc 2017-09-06 16:26:13 +02:00
gsm_data.c implement support for 3-digit MNC with leading zeros 2018-03-07 15:34:48 +00:00
handover_cfg.c cosmetic: adjust copyrights on handover_cfg.c,_vty.c 2018-02-19 16:31:10 +00:00
handover_decision.c HO: introduce ho decision callbacks 2018-02-19 17:11:47 +01:00
handover_decision_2.c cosmetic: typo in log: handover_decision2.c: 'measuements' 2018-03-08 03:33:21 +01:00
handover_logic.c HO: cosmetic: getting a chan activ nack on a non-ho lchan is not an error 2018-02-19 17:11:47 +01:00
handover_vty.c HO: vty: clearly mark 'handover foo' as legacy alias for 'handover1 foo' 2018-02-19 19:01:13 +01:00
meas_rep.c Fix: meas_rep.c will only use valid DL measurement reports 2018-01-21 19:06:58 +00:00
net_init.c implement support for 3-digit MNC with leading zeros 2018-03-07 15:34:48 +00:00
paging.c paging: fix paging attemt rate counter 2018-02-27 07:03:56 +00:00
pcu_sock.c pcu_if: implement support for 3-digit MNC 2018-03-11 00:45:45 +01:00
penalty_timers.c HO: move penalty timers to own file as proper API 2018-02-16 16:11:16 +01:00
rest_octets.c Generate SI2bis Rest Octets 2017-12-12 18:00:56 +00:00
system_information.c sysinfo: Fix regression causing missing L2 Pseudo-Length in SI5/SI6 2018-03-12 00:28:58 +01:00