39 lines
1.4 KiB
Plaintext
39 lines
1.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f92f427a_55b45a92",
|
|
"filename": "src/osmo-bsc/paging.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 263,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2022-11-30T11:57:33Z",
|
|
"side": 1,
|
|
"message": "You already adjust the *_list_len accordingly in paging_remove_request(). I\u0027d suggest to do that in paging_req_timeout_trans() as well if req-\u003eattempts \u003d\u003d 0",
|
|
"revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7c1293f2_d2b0c38e",
|
|
"filename": "src/osmo-bsc/paging.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 263,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-11-30T12:10:00Z",
|
|
"side": 1,
|
|
"message": "So you basically suggesting to move the -- and ++ lines inside paging_req_timeout_trans() within a \"if (req-\u003eattempts\u003d\u003d0)\" conditional block, right?\n\nSo same behavior in the end, just different place. I can do that, it may be clearer for people when reading the lifecycle of requests across the different lists.",
|
|
"parentUuid": "f92f427a_55b45a92",
|
|
"revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |