{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "a67a69ea_5f97f867",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-11-30T12:39:29Z",
      "side": 1,
      "message": "Looks good, just a few minor formatting issues.",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d351c158_d59e1745",
        "filename": "src/osmo-bsc/bsc_vty.c",
        "patchSetId": 1
      },
      "lineNbr": 1058,
      "author": {
        "id": 1000004
      },
      "writtenOn": "2022-11-30T12:43:33Z",
      "side": 1,
      "message": "minor (can be follow-up patch): It might make sense to extend the vty dumping with some information whether the entry is on the initial or the re-transmit list?",
      "range": {
        "startLine": 1045,
        "startChar": 0,
        "endLine": 1058,
        "endChar": 28
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e89b384e_c08f6e33",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-11-30T12:39:29Z",
      "side": 1,
      "message": "spacing issues",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "aacc1f20_d9db6320",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-11-30T12:40:47Z",
      "side": 1,
      "message": "wrong indentation",
      "range": {
        "startLine": 216,
        "startChar": 1,
        "endLine": 216,
        "endChar": 2
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "40461a27_2eb328c6",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000004
      },
      "writtenOn": "2022-11-30T12:43:33Z",
      "side": 1,
      "message": "Ack",
      "parentUuid": "e89b384e_c08f6e33",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "bdb3dfe7_cb65a7a1",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000008
      },
      "writtenOn": "2022-12-01T09:56:50Z",
      "side": 1,
      "message": "Is there a way to include this in our lint job?",
      "parentUuid": "aacc1f20_d9db6320",
      "range": {
        "startLine": 216,
        "startChar": 1,
        "endLine": 216,
        "endChar": 2
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "da8d2c5e_062f6abb",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-12-01T13:03:46Z",
      "side": 1,
      "message": "it could probably extended for that, but I don\u0027t think it\u0027s worth investigating right now. it\u0027s a perl script from the linux kernel (checkpatch).",
      "parentUuid": "bdb3dfe7_cb65a7a1",
      "range": {
        "startLine": 216,
        "startChar": 1,
        "endLine": 216,
        "endChar": 2
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2862818f_ac66d84c",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 216,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-12-01T13:13:03Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "40461a27_2eb328c6",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f92f427a_55b45a92",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 263,
      "author": {
        "id": 1000008
      },
      "writtenOn": "2022-11-30T11:57:33Z",
      "side": 1,
      "message": "You already adjust the *_list_len accordingly in paging_remove_request(). I\u0027d suggest to do that in paging_req_timeout_trans() as well if req-\u003eattempts \u003d\u003d 0",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7c1293f2_d2b0c38e",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 263,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-11-30T12:10:00Z",
      "side": 1,
      "message": "So you basically suggesting to move the -- and ++ lines inside paging_req_timeout_trans() within a \"if (req-\u003eattempts\u003d\u003d0)\" conditional block, right?\n\nSo same behavior in the end, just different place. I can do that, it may be clearer for people when reading the lifecycle of requests across the different lists.",
      "parentUuid": "f92f427a_55b45a92",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "5096a898_0ddb438d",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 263,
      "author": {
        "id": 1000008
      },
      "writtenOn": "2022-11-30T12:12:43Z",
      "side": 1,
      "message": "Yeah, same behavior, just more encapsulated. Otherwise it\u0027s +1 from me",
      "parentUuid": "7c1293f2_d2b0c38e",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "215193ae_5e983785",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 263,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-12-01T13:03:46Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "5096a898_0ddb438d",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6f4069de_fb1f85d0",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 279,
      "author": {
        "id": 1000010
      },
      "writtenOn": "2022-11-30T12:39:29Z",
      "side": 1,
      "message": "This line exceeds the 120 chars-per-line limit.",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "e8e95c19_df47880a",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 279,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-12-01T13:03:46Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "6f4069de_fb1f85d0",
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "27672e38_985b7599",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 532,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-11-30T12:40:47Z",
      "side": 1,
      "message": "indentation",
      "range": {
        "startLine": 532,
        "startChar": 2,
        "endLine": 532,
        "endChar": 3
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "211fc5b0_7b325c6e",
        "filename": "src/osmo-bsc/paging.c",
        "patchSetId": 1
      },
      "lineNbr": 532,
      "author": {
        "id": 1000147
      },
      "writtenOn": "2022-12-01T13:03:46Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "27672e38_985b7599",
      "range": {
        "startLine": 532,
        "startChar": 2,
        "endLine": 532,
        "endChar": 3
      },
      "revId": "e2438ade547cc226af4bc7f2d87d79a90ee3358c",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}