cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

HO: clearly mark conn penalty timer member for hodec2 

The conn's penalty timers will be used only for handover decision 2, make it
clear by a sub-struct.

hodec2 will also initialize the penalty timer list on demand only, so no need
to always initialize.

Change-Id: Ie6c2bc2b10dc424dfd94a9e11a9a62f51c48aa10
This commit is contained in:
Neels Hofmeyr 2018-02-15 14:07:40 +01:00
parent 35ba85c37d
commit ec42264113
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/osmocom/bsc/gsm_data.h
View File

@ -115,7 +115,9 @@ struct gsm_subscriber_connection {
struct llist_head ho_dtap_cache;
unsigned int ho_dtap_cache_len;
struct penalty_timers *ho_penalty_timers;
struct {
struct penalty_timers *penalty_timers;
} hodec2;
/* "Codec List (MSC Preferred)" as received by the BSSAP Assignment Request. 3GPP 48.008
* 3.2.2.103 says:

3
src/libbsc/bsc_api.c
View File

@ -278,7 +278,6 @@ struct gsm_subscriber_connection *bsc_subscr_con_allocate(struct gsm_lchan *lcha
conn->lchan = lchan;
lchan->conn = conn;
INIT_LLIST_HEAD(&conn->ho_dtap_cache);
conn->ho_penalty_timers = penalty_timers_init(conn);
conn->sccp.conn_id = -1;
llist_add_tail(&conn->entry, &net->subscr_conns);
return conn;
@ -353,7 +352,7 @@ void bsc_subscr_con_free(struct gsm_subscriber_connection *conn)
/* drop pending messages */
ho_dtap_cache_flush(conn, 0);
penalty_timers_free(&conn->ho_penalty_timers);
penalty_timers_free(&conn->hodec2.penalty_timers);
llist_del(&conn->entry);
talloc_free(conn);