From e9f420d4878ff205307d6e17b0ee0540e341e002 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Wed, 10 Feb 2016 10:42:20 +0100 Subject: [PATCH] msc: Remove oversimplified todo entry and add a comment Add a comment of why we want to accept this connection anyway. --- openbsc/src/libmsc/osmo_msc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/osmo_msc.c b/openbsc/src/libmsc/osmo_msc.c index b4facff8c..604c100db 100644 --- a/openbsc/src/libmsc/osmo_msc.c +++ b/openbsc/src/libmsc/osmo_msc.c @@ -48,7 +48,11 @@ static int msc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg gsm0408_new_conn(conn); gsm0408_dispatch(conn, msg); - /* TODO: do better */ + /* + * If this is a silent call we want the channel to remain open as long as + * possible and this is why we accept this connection regardless of any + * pending transaction or ongoing operation. + */ if (conn->silent_call) return BSC_API_CONN_POL_ACCEPT; if (conn->loc_operation || conn->sec_operation || conn->anch_operation)