cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

[nat] Remove parameter that is never accessed directly 

The msgb needs to be around when we access the parsed structure
but that needs to be guranteed by the caller handing out the parsed
structure.
This commit is contained in:
Holger Hans Peter Freyther 2010-05-16 16:45:27 +08:00
parent c58da4b374
commit e1fb5670cd
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openbsc/include/openbsc/bsc_nat.h
View File

@ -281,7 +281,7 @@ int bsc_nat_filter_sccp_cr(struct bsc_connection *bsc, struct msgb *msg,
/**
* SCCP patching and handling
*/
int create_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed);
int create_sccp_src_ref(struct bsc_connection *bsc, struct bsc_nat_parsed *parsed);
int update_sccp_src_ref(struct sccp_connections *sccp, struct bsc_nat_parsed *parsed);
void remove_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed);
struct sccp_connections *patch_sccp_src_ref_to_bsc(struct msgb *, struct bsc_nat_parsed *, struct bsc_nat *);

2
openbsc/src/nat/bsc_nat.c
View File

@ -644,7 +644,7 @@ static int forward_sccp_to_msc(struct bsc_connection *bsc, struct msgb *msg)
case SCCP_MSG_TYPE_CR:
if (bsc_nat_filter_sccp_cr(bsc, msg, parsed, &con_type) != 0)
goto exit3;
if (create_sccp_src_ref(bsc, msg, parsed) != 0)
if (create_sccp_src_ref(bsc, parsed) != 0)
goto exit2;
con = patch_sccp_src_ref_to_msc(msg, parsed, bsc);
con->con_type = con_type;

2
openbsc/src/nat/bsc_sccp.c
View File

@ -82,7 +82,7 @@ static int assign_src_local_reference(struct sccp_source_reference *ref, struct
return -1;
}
int create_sccp_src_ref(struct bsc_connection *bsc, struct msgb *msg, struct bsc_nat_parsed *parsed)
int create_sccp_src_ref(struct bsc_connection *bsc, struct bsc_nat_parsed *parsed)
{
struct sccp_connections *conn;

2
openbsc/tests/bsc-nat/bsc_nat_test.c
View File

@ -294,7 +294,7 @@ static void test_contrack()
fprintf(stderr, "Con should not exist %p\n", con_found);
abort();
}
rc = create_sccp_src_ref(con, msg, parsed);
rc = create_sccp_src_ref(con, parsed);
if (rc != 0) {
fprintf(stderr, "Failed to create a ref\n");
abort();