cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

Align syntax of "handover" + "assignment" command with that of lchan act/deact 

We already have other commands that operate on a given bts/trx/ts/ss,
let's make sure they have a shared/common syntax for consistency.

This also fixes the issue that the handover/assignment commands were
active already in VIEW_NODE, while they should only have been in
ENABLE_NODE.

Change-Id: I1f31e9adf9c75348809ebf9f40f6c69fab248e43
This commit is contained in:
Harald Welte 2018-02-12 17:57:57 +01:00 committed by dexter
parent 1231ebe031
commit b22dcb87cf
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/libbsc/bsc_vty.c
View File

@ -1567,9 +1567,10 @@ static int ho_or_as(struct vty *vty, const char *argv[], int argc)
DEFUN(handover_subscr_conn,
handover_subscr_conn_cmd,
"handover <0-255> <0-255> <0-7> <0-7> <0-255>",
"bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> handover <0-255>",
"BTS related commands\n" BTS_NR_STR "Transceiver\n" TRX_NR_STR
"TRX Timeslot\n" TS_NR_STR "Sub-Slot Number\n" LCHAN_NR_STR
MANUAL_HANDOVER_STR
"Current " BTS_TRX_TS_LCHAN_STR
"New " BTS_NR_STR)
{
return ho_or_as(vty, argv, argc);
@ -1577,9 +1578,10 @@ DEFUN(handover_subscr_conn,
DEFUN(assignment_subscr_conn,
assignment_subscr_conn_cmd,
"assignment <0-255> <0-255> <0-7> <0-7>",
MANUAL_ASSIGNMENT_STR
"Current " BTS_TRX_TS_LCHAN_STR)
"bts <0-255> trx <0-255> timeslot <0-7> sub-slot <0-7> assignment",
"BTS related commands\n" BTS_NR_STR "Transceiver\n" TRX_NR_STR
"TRX Timeslot\n" TS_NR_STR "Sub-Slot Number\n" LCHAN_NR_STR
MANUAL_ASSIGNMENT_STR)
{
return ho_or_as(vty, argv, argc);
}
@ -4700,9 +4702,7 @@ int bsc_vty_init(struct gsm_network *network)
install_element_ve(&show_lchan_summary_cmd);
install_element_ve(&show_subscr_conn_cmd);
install_element_ve(&handover_subscr_conn_cmd);
install_element_ve(&handover_any_cmd);
install_element_ve(&assignment_subscr_conn_cmd);
install_element_ve(&assignment_any_cmd);
install_element_ve(&show_paging_cmd);
@ -4867,6 +4867,8 @@ int bsc_vty_init(struct gsm_network *network)
install_element(ENABLE_NODE, &pdch_act_cmd);
install_element(ENABLE_NODE, &lchan_act_cmd);
install_element(ENABLE_NODE, &lchan_mdcx_cmd);
install_element(ENABLE_NODE, &handover_subscr_conn_cmd);
install_element(ENABLE_NODE, &assignment_subscr_conn_cmd);
install_element(ENABLE_NODE, &smscb_cmd_cmd);
install_element(ENABLE_NODE, &ctrl_trap_cmd);