From 9a5bca0b0ea9cbf78e3d816df0d86b28eec85188 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Tue, 28 Jun 2022 04:22:01 +0700 Subject: [PATCH] VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ Found by clang: warning: implicit conversion from enumeration type 'enum lchan_activate_for' to different enumeration type 'enum assign_for' [-Wenum-conversion] This is indeed a bug, because both enum items have different values: * ACTIVATE_FOR_VTY (from enum lchan_activate_for) is 4, * ASSIGN_FOR_VTY (from enum assign_for) is 3. Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 --- src/osmo-bsc/bsc_vty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index fb03d6fdc..5b46e7917 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -774,7 +774,7 @@ static int trigger_as(struct vty *vty, struct gsm_lchan *from_lchan, struct gsm_ vty_out(vty, "Error: cannot find free lchan of type %s%s", gsm_lchant_name(from_lchan->type), VTY_NEWLINE); } - if (reassignment_request_to_lchan(ACTIVATE_FOR_VTY, from_lchan, to_lchan, -1, -1)) { + if (reassignment_request_to_lchan(ASSIGN_FOR_VTY, from_lchan, to_lchan, -1, -1)) { vty_out(vty, "Error: not allowed to start assignment for %s%s", gsm_lchan_name(from_lchan), VTY_NEWLINE); return CMD_WARNING;