From 96df07708371313348d063032ee341592c27defc Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Fri, 25 Nov 2016 23:57:01 +0100 Subject: [PATCH] libmsc/db: avoid subscr->name without terminating NULL char Change-Id: Ic8944ac4c5e940c9d835c52f1701461f274238db Fixes: Coverity CID 57621 --- openbsc/src/libmsc/db.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/openbsc/src/libmsc/db.c b/openbsc/src/libmsc/db.c index 68eba3e17..5cccb3280 100644 --- a/openbsc/src/libmsc/db.c +++ b/openbsc/src/libmsc/db.c @@ -831,8 +831,10 @@ static void db_set_from_query(struct gsm_subscriber *subscr, dbi_conn result) subscr->tmsi = tmsi_from_string(string); string = dbi_result_get_string(result, "name"); - if (string) + if (string) { strncpy(subscr->name, string, GSM_NAME_LENGTH); + subscr->name[sizeof(subscr->name)-1] = '\0'; + } string = dbi_result_get_string(result, "extension"); if (string)