From 67f1c61237c3f90699fcd5d4e141a8b2c6729e0f Mon Sep 17 00:00:00 2001
From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Date: Wed, 6 Dec 2023 03:39:47 +0000
Subject: [PATCH] Update patch set 4

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
---
 628445e613f1ca1759a3754385dde48433bd6cee | 18 ++++++++++++++++
 fba92088383ddeb9116a15409537fd1b03f3fc5c | 27 ++++++++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 fba92088383ddeb9116a15409537fd1b03f3fc5c

diff --git a/628445e613f1ca1759a3754385dde48433bd6cee b/628445e613f1ca1759a3754385dde48433bd6cee
index 173f20e46..939bb7fcf 100644
--- a/628445e613f1ca1759a3754385dde48433bd6cee
+++ b/628445e613f1ca1759a3754385dde48433bd6cee
@@ -16,6 +16,24 @@
       "message": "same",
       "revId": "628445e613f1ca1759a3754385dde48433bd6cee",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "4899a31c_83a5bb8e",
+        "filename": "src/osmo-bsc/bts_vty.c",
+        "patchSetId": 3
+      },
+      "lineNbr": 3231,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2023-12-06T03:39:47Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "c20841af_fa4f6f29",
+      "revId": "628445e613f1ca1759a3754385dde48433bd6cee",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file
diff --git a/fba92088383ddeb9116a15409537fd1b03f3fc5c b/fba92088383ddeb9116a15409537fd1b03f3fc5c
new file mode 100644
index 000000000..a8613d501
--- /dev/null
+++ b/fba92088383ddeb9116a15409537fd1b03f3fc5c
@@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "8881326a_ef45b916",
+        "filename": "src/osmo-bsc/bts_vty.c",
+        "patchSetId": 4
+      },
+      "lineNbr": 3246,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2023-12-06T03:39:47Z",
+      "side": 1,
+      "message": "rationale:\nthe choice is:\na) use fi-\u003eid directly.\nb) osmo_fsm_inst_name() includes the FSM instance pointer address, which makes the vty output untestable. VTY tests are run against the osmo-bsc binary, so where to call osmo_fsm_log_addr(false)? add a new DEFUN to logging_vty.c, wait for it to merge to libosmocore, then call that here in the vty test? Then find out that calling from vty is too late, because osmo_fsm_inst-\u003ename for the timeslots was composed before the test could run the vty command? modify the doc/examples/osmo-bsc/osmo-bsc-minimal.cfg to include that new vty cmd early enough, hopefully; but is the file then still \"minimal\"? so instead add another .cfg file copy specifically for the vty tests.",
+      "range": {
+        "startLine": 3245,
+        "startChar": 65,
+        "endLine": 3246,
+        "endChar": 16
+      },
+      "revId": "fba92088383ddeb9116a15409537fd1b03f3fc5c",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}
\ No newline at end of file