cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

allow mode modify when RTP stream is active 

Get rid of this artificial barrier, because Modify with active voice
stream is supported since commit
"lchan and assignment FSMs: make Channel Mode Modify more sane"
d5cb0eb8fd
I4986844f839b1c9672c61d916eb3d33d0042d747

Change-Id: I25f4a881fa32a07f97d7d6e6b812f8afc699d951
This commit is contained in:
Neels Hofmeyr 2021-06-09 00:55:41 +02:00 committed by neels
parent 9da036fe6e
commit 4906e48376
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/osmo-bsc/lchan_fsm.c
View File

@ -1111,15 +1111,6 @@ static void lchan_fsm_established(struct osmo_fsm_inst *fi, uint32_t event, void
return;
case LCHAN_EV_REQUEST_MODE_MODIFY:
/* FIXME: Add missing implementation to handle an already existing RTP voice stream on MODE MODIFY.
* there may be transitions from VOICE to SIGNALLING and also from VOICE to VOICE with a different
* codec. */
if (lchan->fi_rtp) {
lchan_fail("MODE MODIFY not implemented when RTP voice stream is already active (VOICE => SIGNALLING, VOICE/CODEC_A => VOICE/CODEC_B)\n");
return;
}
modif_info = data;
lchan->modify.info = *modif_info;
lchan->modify.concluded = false;