From 434bb3f39f86cd40b2b737ce5ecc220fa193d5dd Mon Sep 17 00:00:00 2001
From: Harald Welte <laforge@gnumonks.org>
Date: Wed, 22 Dec 2010 19:02:27 +0100
Subject: [PATCH] MNCC: introduce mncc_upq_enqueue() wrapper around
 msgb_enqueue()

This wrapper will allow us to add queue related code at one single
location in the code as opposed to three locations.
---
 openbsc/include/openbsc/gsm_data.h | 6 ++++++
 openbsc/src/gsm_04_08.c            | 2 +-
 openbsc/src/rtp_proxy.c            | 2 +-
 openbsc/src/trau_mux.c             | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h
index b73c4d1ee..c27db85c1 100644
--- a/openbsc/include/openbsc/gsm_data.h
+++ b/openbsc/include/openbsc/gsm_data.h
@@ -840,4 +840,10 @@ int gsm_bts_model_register(struct gsm_bts_model *model);
 struct gsm_subscriber_connection *subscr_con_allocate(struct gsm_lchan *lchan);
 void subscr_con_free(struct gsm_subscriber_connection *conn);
 
+/* FIXME: this should go some other header file, but there is no good one */
+static inline void mncc_upq_enqueue(struct gsm_network *net, struct msgb *msg)
+{
+	msgb_enqueue(&net->upqueue, msg);
+}
+
 #endif
diff --git a/openbsc/src/gsm_04_08.c b/openbsc/src/gsm_04_08.c
index 521dab41c..5eb6a241c 100644
--- a/openbsc/src/gsm_04_08.c
+++ b/openbsc/src/gsm_04_08.c
@@ -1330,7 +1330,7 @@ static int mncc_recvmsg(struct gsm_network *net, struct gsm_trans *trans,
 	if (!msg)
 		return -ENOMEM;
 	memcpy(msg->data, mncc, sizeof(struct gsm_mncc));
-	msgb_enqueue(&net->upqueue, msg);
+	mncc_upq_enqueue(net, msg);
 
 	return 0;
 }
diff --git a/openbsc/src/rtp_proxy.c b/openbsc/src/rtp_proxy.c
index a1f440d09..a2a9107bd 100644
--- a/openbsc/src/rtp_proxy.c
+++ b/openbsc/src/rtp_proxy.c
@@ -443,7 +443,7 @@ static int rtp_socket_read(struct rtp_socket *rs, struct rtp_sub_socket *rss)
 		if (rc < 0)
 			goto out_free;
 		msgb_free(msg);
-		msgb_enqueue(&rs->receive.net->upqueue, new_msg);
+		mncc_upq_enqueue(rs->receive.net, new_msg);
 		break;
 
 	case RTP_NONE: /* if socket exists, but disabled by app */
diff --git a/openbsc/src/trau_mux.c b/openbsc/src/trau_mux.c
index f2fa5c023..67af541a6 100644
--- a/openbsc/src/trau_mux.c
+++ b/openbsc/src/trau_mux.c
@@ -214,7 +214,7 @@ int trau_mux_input(struct gsm_e1_subslot *src_e1_ss,
 		}
 		frame->msg_type = GSM_TCHF_FRAME;
 		frame->callref = ue->callref;
-		msgb_enqueue(&ue->net->upqueue, msg);
+		mncc_upq_enqueue(ue->net, msg);
 
 		return 0;
 	}