cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

compiler warning: chan_compat_with_mode(): clearly handle all enum vals 

Change-Id: I5b3a9a9f0e88b42eed1591632dee1fa00e79f3a3
This commit is contained in:
Neels Hofmeyr 2018-02-27 12:38:28 +01:00
parent 0bfd8d9d37
commit 302f8659b4
1 changed files with 7 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/libbsc/bsc_api.c
View File

@ -423,8 +423,9 @@ static int chan_compat_with_mode(struct gsm_lchan *lchan, int chan_mode, int ful
case GSM_LCHAN_TCH_H:
case GSM_LCHAN_SDCCH:
return 1;
default:
return 0;
}
break;
case GSM48_CMODE_SPEECH_V1:
case GSM48_CMODE_SPEECH_AMR:
case GSM48_CMODE_DATA_3k6:
@ -433,33 +434,20 @@ static int chan_compat_with_mode(struct gsm_lchan *lchan, int chan_mode, int ful
* an explicit override by the 'full_rate' argument */
switch (lchan->type) {
case GSM_LCHAN_TCH_F:
if (full_rate)
return 1;
else
return 0;
break;
return full_rate ? 1 : 0;
case GSM_LCHAN_TCH_H:
if (full_rate)
return 0;
else
return 1;
break;
return full_rate ? 0 : 1;
default:
return 0;
}
break;
case GSM48_CMODE_DATA_12k0:
case GSM48_CMODE_DATA_14k5:
case GSM48_CMODE_SPEECH_EFR:
/* these services all explicitly require a TCH/F */
if (lchan->type == GSM_LCHAN_TCH_F)
return 1;
else
return 0;
break;
return (lchan->type == GSM_LCHAN_TCH_F) ? 1 : 0;
default:
return 0;
}
return 0;
}
/**