cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

follow-up: logging tweak for Immediate Assignment 

follow-up to I9ad094d272254d7aee9b0a676201d4ed8cd727ca because it was merged
before fixeria's code review could be incorporated.

Change-Id: I474cf1a58d1f00ec5b0ae52bd095a60aad763975
This commit is contained in:
Neels Hofmeyr 2018-11-27 11:46:53 +01:00
parent 7ae0f9c271
commit 24482ad4e2
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/osmo-bsc/lchan_fsm.c
View File

@ -97,17 +97,15 @@ static void _lchan_on_activation_failure(struct gsm_lchan *lchan, enum lchan_act
switch (activ_for) {
case FOR_MS_CHANNEL_REQUEST:
if (lchan->activate.immediate_assignment_sent) {
LOG_LCHAN(lchan, LOGL_ERROR,
"lchan activation failed, after Immediate Assignment message was sent (%s)\n",
lchan->last_error ? : "unknown error");
/* Likely the MS never showed up. Just tear down the lchan. */
} else {
if (!lchan->activate.immediate_assignment_sent) {
/* Failure before Immediate Assignment message, send a reject. */
LOG_LCHAN(lchan, LOGL_NOTICE, "Tx Immediate Assignment Reject (%s)\n",
lchan->last_error ? : "unknown error");
rsl_tx_imm_ass_rej(lchan->ts->trx->bts, lchan->rqd_ref);
}
/* Otherwise, likely the MS never showed up after the Assignment, and the failure cause
* (Timeout?) was already logged elsewhere. Just continue to tear down the lchan after
* lchan_on_activation_failure(), no additional action or logging needed. */
break;
case FOR_ASSIGNMENT: