From 1942729fa7f114c6515b7d72f9b1addc7c710f97 Mon Sep 17 00:00:00 2001 From: Pablo Neira Date: Mon, 19 Sep 2011 09:19:09 +0200 Subject: [PATCH] Fix bogus message labelling in wireshark OML dissector While submitting the A-bis OML wireshark dissector I noticed one bug in it that results in bogus message labeling. --- wireshark/0001-abis_oml.patch | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/wireshark/0001-abis_oml.patch b/wireshark/0001-abis_oml.patch index 90f44802c..4295f1f1b 100644 --- a/wireshark/0001-abis_oml.patch +++ b/wireshark/0001-abis_oml.patch @@ -41,7 +41,7 @@ Index: wireshark/epan/dissectors/packet-gsm_abis_oml.c =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ wireshark/epan/dissectors/packet-gsm_abis_oml.c 2011-09-06 13:56:21.000000000 +0200 -@@ -0,0 +1,1744 @@ +@@ -0,0 +1,1746 @@ +/* packet-abis_oml.c + * Routines for packet dissection of GSM A-bis OML (3GPP TS 12.21) + * Copyright 2009-2011 by Harald Welte @@ -588,6 +588,7 @@ Index: wireshark/epan/dissectors/packet-gsm_abis_oml.c + ret = match_strval_idx(val, _oml_fom_msgtype_vals, &idx); + if (!ret) + return NULL; ++ return &(_oml_fom_msgtype_vals[idx]); + } + return &(vs->_vs_p[idx]); +} @@ -602,6 +603,7 @@ Index: wireshark/epan/dissectors/packet-gsm_abis_oml.c + ret = match_strval_idx(val, _oml_fom_attr_vals, &idx); + if (!ret) + return NULL; ++ return &(_oml_fom_attr_vals[idx]); + } + return &(vs->_vs_p[idx]); +}