cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3: Code-Review+1

> Seems like a change to make a change. What issue was too difficult
 > to debug?

I remember during dyn TS and the following BROKEN_UNUSABLE recovery issue seeing state changes and spending time to figure out where those transitions came from. I think logging the line nrs is super handy and desirable.

 > call sites). Sure now __LINE__ points to the right place but you
 > can not put a breakpoint on state changes anymore.

That is a valid point. This could be solved by using the scheme we have in place e.g. with the FSMs: https://git.osmocom.org/libosmocore/tree/include/osmocom/core/fsm.h#n169

  #define osmo_fsm_inst_state_chg(fi, new_state, timeout_secs, T) \
  	_osmo_fsm_inst_state_chg(fi, new_state, timeout_secs, T, \
  				 __BASE_FILE__, __LINE__)
  int _osmo_fsm_inst_state_chg(struct osmo_fsm_inst *fi, uint32_t new_state,
  			     unsigned long timeout_secs, int T,
  			     const char *file, int line);

i.e. still have an actual function, but provide a macro wrapper to add line info.

Patch-set: 3
Reviewer: Neels Hofmeyr <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1
This commit is contained in:
Neels Hofmeyr 2017-09-06 13:58:27 +00:00 committed by Gerrit Code Review
parent 143c0eeefd
commit 183e41239f
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available