cellular-infrastructure
/
osmo-bsc
mirror of https://gerrit.osmocom.org/osmo-bsc
9
0
Fork 0
Code Issues Releases Wiki Activity

gsm_04_80: Avoid using deprecated API 

gsm_04_80_utils.c: In function ‘bsc_send_ussd_release_complete’:
gsm_04_80_utils.c:37:9: warning: ‘gsm0480_create_ussd_release_complete’ is deprecated: Use gsm0480_create_release_complete() instead. [-Wdeprecated-declarations]
   37 |  struct msgb *msg = gsm0480_create_ussd_release_complete();
      |         ^~~~
  CC       gsm_data.o
In file included from gsm_04_80_utils.c:22:
/usr/local/include/osmocom/gsm/gsm0480.h:120:14: note: declared here
  120 | struct msgb *gsm0480_create_ussd_release_complete(void)
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The commit is not changing the existing logic/assumption: TID 0 should
not be in use by anything else at the point the USSD is generated.

Change-Id: I739158dec62cd5f0c2080fbb426af9c024baef87
This commit is contained in:
Harald Welte 2019-12-04 14:47:21 +01:00 committed by laforge
parent f659f5e5b0
commit 01a3c2689c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/osmo-bsc/gsm_04_80_utils.c
View File

@ -34,7 +34,8 @@ int bsc_send_ussd_notify(struct gsm_subscriber_connection *conn, int level,
int bsc_send_ussd_release_complete(struct gsm_subscriber_connection *conn)
{
struct msgb *msg = gsm0480_create_ussd_release_complete();
/* ugly: we obviously don't know if TID 0 is currently in user for the given subscriber... */
struct msgb *msg = gsm0480_create_release_complete(0);
if (!msg)
return -1;
gscon_submit_rsl_dtap(conn, msg, 0, 0);