cellular-infrastructure
/
openggsn
Archived
9
0
Fork 0
Code Releases Activity

queue_new(): fix NULL dereference on allocation failure 

Coverity complains about a 'Dereference before null check' on *queue.
So, push the NULL check further up.

Though I doubt that 'return EOF' is the proper way to handle allocation
failure, this patch is only about the NULL dereference.

Fixes: CID#57918
This commit is contained in:
Neels Hofmeyr 2016-04-25 13:00:10 +02:00 committed by Harald Welte
parent b29ff1da55
commit f89dc4e127
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gtp/queue.c
View File

@ -127,16 +127,15 @@ int queue_new(struct queue_t **queue)
if (QUEUE_DEBUG)
printf("queue_new\n");
*queue = calloc(1, sizeof(struct queue_t));
if (!(*queue))
return EOF;
(*queue)->next = 0;
(*queue)->first = -1;
(*queue)->last = -1;
if (QUEUE_DEBUG)
queue_print(*queue);
if (*queue)
return 0;
else
return EOF;
return 0;
}
/*! \brief Deallocates queue structure */