From 45ff1d2e62538dea14c7190617f561dd1f93654a Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 25 Nov 2020 17:48:25 +0100 Subject: [PATCH] main: generate coredump and exit upon SIGABRT received Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Fixes: OS#4865 Change-Id: I3caa78e6ce7c9a98b0a26fde61468bd7b38c6fd9 --- rtpsource/rtpsource.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/rtpsource/rtpsource.c b/rtpsource/rtpsource.c index d5ffce5..d966a4f 100644 --- a/rtpsource/rtpsource.c +++ b/rtpsource/rtpsource.c @@ -198,8 +198,16 @@ static void signal_handler(int signal) { switch (signal) { case SIGABRT: - /* in case of abort, we want to obtain a talloc report - * and then return to the caller, who will abort the process */ + /* in case of abort, we want to obtain a talloc report and + * then run default SIGABRT handler, who will generate coredump + * and abort the process. abort() should do this for us after we + * return, but program wouldn't exit if an external SIGABRT is + * received. + */ + talloc_report_full(g_tall_ctx, stderr); + signal(SIGABRT, SIG_DFL); + raise(SIGABRT); + break; case SIGUSR1: talloc_report_full(g_tall_ctx, stderr); break;