This change fixes a parallel building problem, when
submit_multi_resp_test
was being compiled before its libsmpp34 dependency:
make[2]: *** No rule to make target '../binaries/libsmpp34.la',
needed by 'submit_multi_resp_test'. Stop.
make[2]: *** Waiting for unfinished jobs....
For some reason, automake ignores a dependency if the full
path is provided:
$(top_builddir)/binaries/libsmpp34.la
while the relative path solves the problem:
libsmpp34.la
Change-Id: I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.
Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: I0030c8662fa87fb589582a3f6bde6ed53e8e3ef9
Commit 1648066f16 introduced
osmocom-style git-version-gen, .version, etc. - but failed
to include .version in the EXTRA_DIST list of files.
Change-Id: If191e82677d851ca486ec78da6643958d05eb5f6
The code in OCTET8 implementation assumes the len is placed inside the
byte preceding the memory buffer, which is true for the defined cases.
However, it creates a compilation warning. Better pass the value
directly from the struct field rather than playing addr games. this way
we also assert we require to explicitly pass the len.
Fixes lots of warning like the one below:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_u
npack’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:147:14: warning: array
subscript is above array bounds [-Warray-bounds]
lenval = *((inst par) - 1);\
^~~~~~~~~~~~~~~~~
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/def_frame/submit_sm.frame:18:2: note: in e
xpansion of macro ‘OCTET8’
OCTET8( instancia, short_message, 254 );
^~~~~~
Change-Id: Id110f4e977c3becdb44cf5492c372e530ea51551
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c: In function ‘main’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:58: warning: ‘snprintf’ output
truncated before the last format character [-Wformat-truncation=]
snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
^
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/test_pdu/bind_receiver_resp_test.c:55:5: note: ‘snprintf’ output 17
bytes into a destination of size 16
snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "1234567890123456");
Change-Id: I4ec682a5e2ee4d02008a9c86a0a5507792667d0e
Fixes compilation warning below:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c: In function ‘smpp34_unpack’:
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_unpack.c:232:18: warning: variable ‘l’ set but not used [
-Wunused-but-set-variable]
uint32_t l;
Change-Id: I75baa65b575deec1cc040490f2e76ebb54e46ca7
Fixes compilation warning below:
%s’ directive output may be truncated writing between 8 and 33 bytes into a regio
n of size 30 [-Wformat-truncation=]
snprintf(buff, SMALL_BUFF, "%s",
^~
/home/pespin/dev/sysmocom/bin/../git/libsmpp34/src/smpp34_params.c:136:5: note: ‘
snprintf’ output between 9 and 34 bytes into a destination of size 30
snprintf(buff, SMALL_BUFF, "%s",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#define OPERACION( p_tlv_id ) (tlv_id == p_tlv_id)?#p_tlv_id:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#include "def_list/tlv_id.list"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Reserved"
~~~~~~~~~~
#undef OPERACION
~~~~~~~~~~~~~~~~
);
Change-Id: Ie2ba6182eb0cdd98cadb8317aef49141244aa92d
Fixes compilation warning below:
smpp34_dumpBuf.c:52:9: warning: variable ‘lefterror’ set but not used [-Wunused-but-set-variable]
int lefterror = 0;
Change-Id: Iea8ff80d3e4d16aaca6e37d64593b50fa27c8cfb
We have a particular method of generating package version information
in the Osmocom project, based on a 'git-version-gen' script that
looks up the latest git tag and generates a version from that.
This version is then used in pkgconfig, etc.
Change-Id: I1e6ed7af7107f8a74010721acd34f92a3237a7a1
The registered_delivery field in SMPP message is a toggle on/off, this
patch adds two new definition so we don't have to use magic numbers from
the code.
Change-Id: I5b3afff1b3b77cccd949e0606914c7ac3ba6114c
Add special message attributes definitions that are associated with the
short message. Thus, we can get rid of magic numbers in our codebase.
Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65
Make sure the version number of this sourcepackage is higher than
the one found in Debian SID.
Change-Id: I77126b0b9a8dbc4dcdc02a5a3b4718129b308930
Reviewed-on: https://gerrit.osmocom.org/112
Tested-by: Jenkins Builder
Reviewed-by: Holger Freyther <holger@freyther.de>
Martin Hauke
Harald Welte
Max
Pau Espin
Neels Hofmeyr