From 3cf5229fa0502e759d45e8397b2e7341ab418165 Mon Sep 17 00:00:00 2001 From: Stefan Sperling Date: Wed, 21 Nov 2018 13:20:15 +0100 Subject: [PATCH] fix use of partly initialized struct in tcp test Properly initialize sockaddr 'name' used by tcp test, and remove a redundant re-declaration of this variable in a nested scope. Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3 Related: CID#188848 --- test_apps/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test_apps/tcp.c b/test_apps/tcp.c index 4e24fa5..4cf681d 100644 --- a/test_apps/tcp.c +++ b/test_apps/tcp.c @@ -69,7 +69,7 @@ int do_tcp_connect( xmlNodePtr p, int *s ) /* bind to a local addr */ if (strlen(local_src) != 0) { - struct sockaddr_in name; + memset(&name, 0, sizeof(name)); name.sin_family = AF_INET; name.sin_port = htons(local_port); name.sin_addr.s_addr = inet_addr(local_src); @@ -91,6 +91,7 @@ int do_tcp_connect( xmlNodePtr p, int *s ) }; memcpy(&addr.s_addr, _host.h_addr_list[0], sizeof(struct in_addr)); + memset(&name, 0, sizeof(name)); name.sin_family = AF_INET; name.sin_port = htons( port ); name.sin_addr = addr;