GCC 10.2.1 20210110 from Debian 11 generates an invalid Warray-bounds
error. It was fixed in future GCC versions, I verified it with GCC
11.3.0. Ignore the warning, so we can build on Debian 11 with -Werror.
Fix for:
INTEGER.c: In function ‘asn_int642INTEGER’:
INTEGER.c:1340:34: error: array subscript 0 is outside array bounds of ‘int64_t[1]’ {aka ‘long int[1]’} [-Werror=array-bounds]
1340 | for(pstart = p, bp = buf, pend1 += add; p != pend1; p += add)
| ~~~~~~^~~~~~
INTEGER.c:1296:42: note: while referencing ‘value’
1296 | asn_int642INTEGER(INTEGER_t *st, int64_t value) {
| ~~~~~~~~^~~~~
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93582
Change-Id: Ic10407e6d484ae29dc39edbdc6fcd0145e17e773
In debian, this Osmocom fork of libasn1c is packaged as osmo-libasn1c.
Add related Replaces: and Conflicts: to debian/control, so there is no
error when installing osmo-libasn1c from Debian first, then configuring
the Osmocom package repositories and trying to install libasn1c from
there.
Fix for:
Preparing to unpack .../08-libasn1c1_0.9.34.1.71cb.202302010006_amd64.deb ...
Unpacking libasn1c1:amd64 (0.9.34.1.71cb.202302010006) ...
dpkg: error processing archive /tmp/apt-dpkg-install-8zK3sm/08-libasn1c1_0.9.34.1.71cb.202302010006_amd64.deb (--unpack):
trying to overwrite '/usr/lib/x86_64-linux-gnu/libasn1c.so.1.0.1', which is also in package osmo-libasn1c1:amd64 0.9.32-1+b1
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Related: OS#5318
Related: https://salsa.debian.org/debian-mobcom-team/osmo-libasn1c/-/blob/master/debian/control
Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Binary_Packages
Change-Id: I5116df35b5819c22a184057cdf6ed756974d6388
The build failures complain about misleading indentation:
../../../src/libasn1c/src/per_decoder.c:161:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
161 | if(!td->aper_decoder)
| ^~
../../../src/libasn1c/src/per_decoder.c:163:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
163 | rval = td->aper_decoder(opt_codec_ctx, td, 0, sptr, &pd);
| ^~~~
Change-Id: I9ebd0de9135722bb718e2a5067f9b8238d0483dc
As pointed out at https://github.com/libexpat/libexpat/issues/312
libtool does not play nice with clang sanitizer builds at all. For those
builds LD shoud be set to clang too (and LDFLAGS needs the sanitizer
flags as well), because the clang compiler driver knows how linking to
the sanitizer libs works, but then at a later stage libtool fails to
actually produce the shared libraries and the build fails. This is fixed
by this patch.
Addtionally LD_LIBRARY_PATH has no effect on conftest runs during
configure time, so the rpath needs to be set to the asan library path to
ensure the configure run does not fail due to a missing asan library,
i.e.:
SANS='-fsanitize=memory -fsanitize-recover=all -shared-libsan' export
CC=clang-10 ASANPATH=$(dirname `$CC
-print-file-name=libclang_rt.asan-x86_64.so`) export
LDFLAGS="-Wl,-rpath,$ASANPATH $SANS $LDFLAGS"
Change-Id: Ie38fa9985187c76b4e456d8b0a83006ef341b97e
Remove OpenSUSE bug report link, set version to @VERSION@, make it build with CentOS 8 etc.
Related: OS#4550
Change-Id: Ic075dd5a53cc76cf1b6aeca5c31db495882db915
This reverts commit a352642587d8835deb3c6f55da7986f427835157.
I've confused the libasn1c and asn1c repositories. libasn1c does not
need this workaround, asn1c does.
Related Change-Id: I80eecc60b96e87710218089dfdd1a3f87b40a8b1 (asn1c)
Change-Id: I73eac905524688939e133b6f91ad85514dc0393a
Avoid a race condition that causes the build to fail on Jenkins with:
asn1p_y.y: In function 'asn1p_parse':
asn1p_y.y:357:13: error: 'param' undeclared (first use in this function)
*(void **)param = $1;
^~~~~
Change-Id: Ib853a93bffc4cd78d4f08624fb1e56772ce68ce5
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Related: OS#3449
Change-Id: I61a7995edf9fbc06db88ab391d32a988c3760c19
The pkgconf file contains an unknown version which result in failure
of other packages which depend on a minimum version (osmo-iuh)
Change-Id: I65401786cf9eb63d3445f548dc13c1d3f9f4c1ea
We updated to 0.9.29 tag, but configure.ac was locked to 0.9.28, which
means release 0.9.29 is going to generated an old version and thus is
broken. A new release will follow this commit.
Change-Id: I8e1665f21d1bc76922423cabad3df72a2502f559
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
Maintain these exceptions from -Werror:
a) deprecation (allow upstream to mark deprecation without breaking builds);
b) "#warning" pragmas (allow to remind ourselves of errors without breaking
builds)
As a last configure step before generating the output files, print the complete
CFLAGS and CPPFLAGS by means of AC_MSG_RESULT.
Change-Id: Ibcc8238584a585434b39a046cd2d7e18ddaf7f8c
See osmo-ci change I2409b2928b4d7ebbd6c005097d4ad7337307dd93 for rationale.
Depends: I2409b2928b4d7ebbd6c005097d4ad7337307dd93
Change-Id: If5d252dc679e47a8375361d0ff278b7b98768f26
The warning is, on FreeBSD,
CC asn1helpers.lo
asn1helpers.c:68:10: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare]
if (len < 0)
~~~ ^ ~
Change-Id: I80867da697d744d7ef4d70c8f24031f5781fb11a
libasn1c is using libm[ath] symbols from REAL.c and hence should be
linked using '-lm' to carry a dynamic linker dependency itself.
We shouldn't use a pkg-config hack to ask applications to do this on
our behalf.
Change-Id: Ie107f7252eeed90233468deaef57d3cee36abdf4
All of this code is from asn1c 0.9.28, so let's make sure
autoconf + debian packaging agree on the version numbering
Change-Id: Ie8dc8f5df7123d4bf7579f6f4e84b7cc33d49607
/usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
# warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
^~~~~~~
Change-Id: I442e60413b3bee6d365cd5df672a558d68998670
In file included from asn1helpers.c:14:0:
../include/asn1c/asn1helpers.h: In function ‘OCTET_STRING_noalloc’:
../include/asn1c/asn1helpers.h:26:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
s->buf = str;
^
Change-Id: Ie2fefe710090de779137c36b98239ef4a097b6dd
The license is not a 3-clause BSD, but a 2-clause BSD. Couldn't
find any trace to a 3rd clause anywhere.
Change-Id: I4f908ce4f670e062e6808ac7966d0e52bfe6b4f9
asn1helpers.c originally existed in the repository of an application
(osmo-hnbgw, IIRC), and hence was under AGPLv3. When moving it to
this repository, it should have been relicensed but wasn't. The
intention was never to "contaminate" (lib)asn1c with AGPLv3 code.
Change-Id: I8e714d4c51d771b1eabec7aa06e7daae73f48b15
When decoding a constrained integer with a lower boundary, we need
to make sure the lower bound is added after decoding the raw offset
inside the range.
Before this change, RANAP_CauseMisc_unspecified_failure (115) would be
encoded as 2 (115 - 113 = 2), but would be decoded as 2, rather than
113+2 = 115.
Code for this was taken from
openairinterface5g/openair3/S1AP/MESSAGES/ASN1/asn1cpatch.p0 which
unfortunately doesn't carry much of a revision history :/
The number of bytes used by an APER encoded integer depends on its
actually encoded value, not on the maximum value that could be possibly
encoded.
The old code would e.g. always use 24 bits if the maximum encoded value
would require 24 bits.
To give an example RANAP MaxBitrate (INTEER 1 .. 16000000) value 64000
was previously encoded as "80 00 f9 ff", while it is now the correct
representation "40 f9 ff".
Thanks to Dieter Spaar for detecting this problem in the Osmo-IUH
generated RANAP output, and thanks to openairinterface for fixing the
bug in their code (sadly not contributed to upstream asn1c, though).
The libosmocore depedency is used for talloc and OSMO_ASSERT.
Reduce the depedencies by using libtalloc directly and replace
the ASSERT with a local one (without backtrace support).
When encoding an INTEGER, we need to subtract the lower bound before
encoding the value. This is specified in Clause 10.5.7.x of X.691.
The decoder already does this correct, but the encoder was wrong.
... which in turn causes all the ASN_DEBUG() to be turned into
fprintf(stderr, ...) statements, once the user application decides
to set 'asn_debug = 1' somewhere in its code.
The next step would be to make _ASN_DECODE_FAILED / _ASN_ENCODE_FAILED
no longer depend on ASN_DEBUG (which it currently does)
Alexander Couzens
