Currently the connect is blocking leading to one bad connection
(e.g. to a black hole) blocking all other connections leading to
bursty traffic.
Change-Id: Idfca8acbce09176055da3e577566386e07d7a348
There seems to be issues with the write handling of the osmo-stp
and so far we did not enable vty tests here. Make it possible to
enable the tests, fix the VTY strings, change string to OsmoSTP.
Change-Id: I547fd4840d86ce16e8589fb63802dd7099781194
mgcp/mgcp_protocol.c: In function ‘mgcp_handle_message’:
/home/ich/install/openbsc/include/osmocom/core/logging.h:59:4: warning: ‘save’ may be used uninitialized in this function [-Wmaybe-uninitialized]
logp2(ss, level, __BASE_FILE__, __LINE__, 0, fmt, ##args); \
^
mgcp/mgcp_protocol.c:368:15: note: ‘save’ was declared here
char *elem, *save;
Change-Id: I28152373b043c8a5b55a83ac09dd7bafce4d2d66
The return type changed from enum to int and it is time to catch
up with it.
vty_interface.c:108:2: warning: initialization from incompatible pointer type
.go_parent_cb = ss7_go_parent,
^
vty_interface.c:108:2: warning: (near initialization for ‘vty_info.go_parent_cb’)
mgcp_ss7_vty.c:36:2: warning: initialization from incompatible pointer type
.go_parent_cb = mgcp_go_parent,
^
mgcp_ss7_vty.c:36:2: warning: (near initialization for ‘vty_info.go_parent_cb’)
Change-Id: I8061df697daf79fa57b8313c15f6567ff152f4a5
For M3UA we already skip the link-test handling and there is no
point in waiting for management messages to collect routing info.
We already know where to send things. At first I tried to overload
the skip handling but it is better to just set the timer to 0 and
then move on.
For M3UA we should have one time-out for operation we want and
then re-transmit it. As this is too much work right now create
a single timer that waits that after a connect the ASPAC_ACK
state will be reached.
In case of back pressure we can not send messages quick enough
and will drop messages. Add a counter so we can count how often
this happened per link/linkset. The SCTP M2UA code is not changed
as we don't have a link in the hands and adding it is too risky
without tests (not all M2UA have a link index so some might not
have a link).
For the "bridging" to IPA mode we can force the SCTP/M3UA connection
down. This way the remote STP will do a proper link fail-over
procedure instead of the STP throwing data away.
This is not configurable yet.
For M3UA links we can't send SLTM messages but we can
assume that the link is fine. Add a flag that a link
can set in case SLTM should be skipped. The linkset will
then directly wait for routable DPCs and bring the
SCCP part up.
Make it possible to configure the transmit power. These settings
will be in effect immediately (there is no lock between the two
threads but it is a read only).
When an endpoint is allocated we do not have enough resources to
connect it again and this situation is permanent as long as the
endpoint is connected.
Returning 502 might help some switches to release stale audio resources.
Playing tones should be printable ascii characters, begin by checking
for NULL (as it happened before) as the first illegal tone. This is
an attempt to make the API more robust and detect errors more early.
Because of the issue parsing the MGCP request a '\0' was added to
the queue. This lead to the dtmf scheduler believing that a play
was in progress while the playing code didn't play anything. This
lead to the queue to be stuck and nothing being played at all.
Return the number of tones that should be played and stop using
strlen on the tones.
The RQNT message might not contain a 'S:' line with the actual tone
to play. Instead of calling the callback with the 0 as tone just leave
early.
Example:
X: 6B9519B88F0
R: D/[0-9#*](N), G/ft, fxr/t38
Merged from the OpenBSC development tree
For some equipment it is the easiest to patch the assignment
complete message transported to the MSC. Add a VTY config to
enable this patching, create a testcase that tests that the
original message is truncated. The setting of the VTY option
has been manually tested. The entire system has not been end
to end tested.
Neels Hofmeyr
Sylvain Munaut