Previous script didn't clean workspace and git repositories were
allegedly not being updated, hiding build failures against newer deps.
Currently cellmgr-ng is not being maintained and fails to build against
recent libosmo-sccp. For that dep repo, tag "old_sua" is used since
after that tag, APIs changed considerably and it is known that
cellmgr-ng cannot build starting from there.
It's up to whoever wants to maintain it to make changes in cellmgr-ng to
support newer libosmo-sccp.
While building with new jenkins.sh script and "old_sua" tag, still there
are some build issues (mostly related to build system), like some
Makefile.am files missing some LDFLAGS. Some of them are fixed in
follow-up patches. Some other are left as an exercise for whover wants
to revive this repo.
There seems to be issues with the write handling of the osmo-stp
and so far we did not enable vty tests here. Make it possible to
enable the tests, fix the VTY strings, change string to OsmoSTP.
Provide a modern systemd service file for the osmo-stp. The sysvinit
file is quite basic and doesn't signal syntax errors nicely. Let us
embrace the future.
mgcp/mgcp_protocol.c: In function ‘mgcp_handle_message’:
/home/ich/install/openbsc/include/osmocom/core/logging.h:59:4: warning: ‘save’ may be used uninitialized in this function [-Wmaybe-uninitialized]
logp2(ss, level, __BASE_FILE__, __LINE__, 0, fmt, ##args); \
mgcp/mgcp_protocol.c:368:15: note: ‘save’ was declared here
char *elem, *save;
The return type changed from enum to int and it is time to catch
up with it.
vty_interface.c:108:2: warning: initialization from incompatible pointer type
.go_parent_cb = ss7_go_parent,
vty_interface.c:108:2: warning: (near initialization for ‘vty_info.go_parent_cb’)
mgcp_ss7_vty.c:36:2: warning: initialization from incompatible pointer type
.go_parent_cb = mgcp_go_parent,
mgcp_ss7_vty.c:36:2: warning: (near initialization for ‘vty_info.go_parent_cb’)
For M3UA we already skip the link-test handling and there is no
point in waiting for management messages to collect routing info.
We already know where to send things. At first I tried to overload
the skip handling but it is better to just set the timer to 0 and
then move on.
For M3UA we should have one time-out for operation we want and
then re-transmit it. As this is too much work right now create
a single timer that waits that after a connect the ASPAC_ACK
state will be reached.
In case of back pressure we can not send messages quick enough
and will drop messages. Add a counter so we can count how often
this happened per link/linkset. The SCTP M2UA code is not changed
as we don't have a link in the hands and adding it is too risky
without tests (not all M2UA have a link index so some might not
have a link).
For the "bridging" to IPA mode we can force the SCTP/M3UA connection
down. This way the remote STP will do a proper link fail-over
procedure instead of the STP throwing data away.
This is not configurable yet.