cellular-infrastructure
/
cellmgr-ng
Archived
9
0
Fork 0
Code Releases Activity

sctp: Really apply the MSC workaround 

The MSC workaround was added in 5960ba387a
but it has never worked as in 8fd28dbbe6 (earlier)
we were checking for link->conn != conn in the dispatch method. Move the
code over to the generic dispatch and check for NULL.
This commit is contained in:
Holger Hans Peter Freyther 2011-08-10 06:40:17 +02:00
parent 54250f9e1f
commit c495daeeb2
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/sctp_m2ua.c
View File

@ -311,22 +311,6 @@ static int m2ua_handle_state_req(struct mtp_m2ua_link *link,
uint32_t index;
int req;
/* fixup for a broken MSC */
if (link->conn != conn) {
if (!link->conn) {
LOGP(DINP, LOGL_NOTICE,
"No ASP Activate but no connection is on link-index %d.\n",
link->link_index);
link->conn = conn;
link->asp_active = 1;
} else {
LOGP(DINP, LOGL_ERROR,
"Someone forgot the ASP Activate on link-index %d\n",
link->link_index);
return -1;
}
}
state = m2ua_msg_find_tag(m2ua, M2UA_TAG_STATE_REQ);
if (!state || state->len != 4) {
LOGP(DINP, LOGL_ERROR, "Mandantory state request not present.\n");
@ -474,6 +458,15 @@ static int m2ua_handle_maup(struct mtp_m2ua_link *link,
return -1;
}
/* fixup for a broken MSC */
if (!link->conn && m2ua->hdr.msg_type == M2UA_MAUP_STATE_REQ) {
LOGP(DINP, LOGL_NOTICE,
"No ASP Activate but no connection is on link-index %d.\n",
link->link_index);
link->conn = conn;
link->asp_active = 1;
}
if (link->conn != conn) {
LOGP(DINP, LOGL_ERROR,
"Someone forgot the ASP Activate on link-index %d\n",