acouzens
/
osmo-ttcn3-hacks
forked from ttcn3/osmo-ttcn3-hacks
1
0
Fork 0
Code Pull Requests Activity

GPRS_Components: confirm only when requested 

We currently send a confirmation back when the SAPI was PCH. This is no
longer correct. We now have to check if the receiving end has actually
requested a confirmation.

Related: OS#5927
Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2
This commit is contained in:
Philipp Maier 2023-09-21 15:36:00 +02:00
parent 7a2d959117
commit 8a4d0e09b1
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pcu/GPRS_Components.ttcn
View File

@ -1070,8 +1070,10 @@ runs on MS_BTS_IFACE_CT {
t_imm_ass)) -> value data_msg {
rr_imm_ass := data_msg.rr_msg;
log("Rx Immediate Assignment: ", rr_imm_ass);
/* Send DATA.cnf back to the IUT (only needed for PCH) */
f_pcuif_tx_data_cnf(data_msg);
/* Send DATA.cnf back to the IUT */
if (ispresent(data_msg.confirm) and data_msg.confirm) {
f_pcuif_tx_data_cnf(data_msg);
}
setverdict(pass);
}
}
@ -1187,8 +1189,10 @@ runs on MS_BTS_IFACE_CT return GsmRrMessage {
f_shutdown(__BFILE__, __LINE__);
}
/* Send DATA.cnf back to the IUT (only needed for PCH) */
f_pcuif_tx_data_cnf(data_msg);
/* Send DATA.cnf back to the IUT */
if (ispresent(data_msg.confirm) and data_msg.confirm) {
f_pcuif_tx_data_cnf(data_msg);
}
return rr_pag_req1;
}